Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript): str_split #67

Closed

Conversation

nblfikr
Copy link
Contributor

@nblfikr nblfikr commented Oct 9, 2022

  • Programming langugage: Typescript

  • Function(s) that I'm implementing: str_split

  • Issue number: Typescript Implementation #18

  • I have created unit tests to support my implementation

  • I have created in-code documentation (or docstring) to document my code

  • [] (Optional) I have updated the README.md file to document the function I'm implementing

@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (9c3a181) compared to base (f9d48b1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##            master       #67    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           47         5    -42     
  Lines          597        29   -568     
  Branches         5         8     +3     
==========================================
- Hits           597        29   -568     
Flag Coverage Δ
clojure ?
csharp ?
go ?
rust ?
typescript 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
typescript/src/string/str_split.ts 100.00% <100.00%> (ø)
rust/tests/string_test/implode_test.rs
go/trim.go
spec/pehape/string/echo_spec.rb
csharp/Pehape/String/Explode.cs
rust/tests/common/mod.rs
spec/pehape/string/lcfirst_spec.rb
spec/pehape/string/hex2bin_spec.rb
spec/pehape/string/implode_spec.rb
go/lcfirst.go
... and 34 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@aldy505 aldy505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ada merge conflict


const str = "Hello World!";

describe("string split", () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handle juga:

  1. kalo parameter str pertamanya kosong
  2. kalo parameter str nya 10 karakter, tapi parameter len nya 3. apakah akan jadi ["Aaa", "Bbb", "Ccc". "D"] atau gimana?

@aldy505 aldy505 requested review from arnoldart and elianiva October 10, 2022 03:15
@nblfikr nblfikr closed this Oct 10, 2022
@nblfikr nblfikr force-pushed the feat-typescript/str_split branch from 9c3a181 to 7c9e378 Compare October 10, 2022 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants