Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript-lcfirst): lowercase the first characters of the text #65

Merged
merged 4 commits into from
Oct 13, 2022

Conversation

ddouble-d
Copy link
Contributor

  • Programming langugage: TypeScript

  • Function(s) that I'm implementing: lcfirst

  • Issue number: Typescript Implementation #18

  • I have created unit tests to support my implementation

  • I have created in-code documentation (or docstring) to document my code

  • (Optional) I have updated the README.md file to document the function I'm implementing

@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (43e313c) compared to base (f9d48b1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##            master       #65    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           47         5    -42     
  Lines          597        15   -582     
  Branches         5         5            
==========================================
- Hits           597        15   -582     
Flag Coverage Δ
clojure ?
csharp ?
go ?
rust ?
typescript 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
typescript/src/string/lcfirst.ts 100.00% <100.00%> (ø)
go/ucwords.go
go/strrev.go
spec/pehape/string/strrev_spec.rb
spec/pehape/string/ord_spec.rb
csharp/Pehape/String/Explode.cs
go/chr.go
rust/src/string/implode.rs
spec/pehape/string/implode_spec.rb
clojure/src/pehape/string/levenshtein.clj
... and 34 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aldy505
Copy link
Member

aldy505 commented Oct 8, 2022

ada merge conflict

@aldy505 aldy505 requested review from arnoldart and elianiva October 8, 2022 04:30
typescript/src/string/lcfirst.ts Show resolved Hide resolved
typescript/src/string/lcfirst.test.ts Show resolved Hide resolved
@aldy505 aldy505 requested a review from elianiva October 8, 2022 11:12
@ddouble-d
Copy link
Contributor Author

hi @elianiva
can you re-review if you don't mind?

@aldy505 aldy505 merged commit f7f9cd1 into teknologi-umum:master Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants