Feat-Ruby: add crc32, sha1, and md5 function #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #54 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 29 17 -12
Lines 305 135 -170
Branches 4 0 -4
==========================================
- Hits 305 135 -170
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
aldy505
approved these changes
Oct 6, 2022
|
|
||
| module Pehape | ||
| def self.sha1_file(filename, binary=nil) | ||
| return false unless File.exist?(filename.to_s) |
There was a problem hiding this comment.
kalo di php emang dia return false kalo filenya ngga exist?
|
|
||
| module Pehape | ||
| def self.md5_file(filename, binary=nil) | ||
| return false unless File.exist?(filename.to_s) |
There was a problem hiding this comment.
kalo di php emang dia return false kalo file ngga exists?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #3