Enable preview lint checks of ruff #3544
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See [1]: preview rules are sometimes interesting rules, but they are not enabled and ruff community collects opinions before deciding whether a rule is worth eing enabled by default. And there are some useful rules, I'd like to start enabling them in smaller groups, to make review easier. Starting with this patch and already enabled rules. [1] https://docs.astral.sh/ruff/preview/#preview
happz
added
code | no functional change
happz
requested review from
psss,
lukaszachy,
thrix,
janhavlin and
martinhoyer
as code owners
happz
force-pushed
the
bump-pre-commit-checks-1.44
branch
2 times, most recently
from
7f9b047 to
cdbd8c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See [1]: preview rules are sometimes interesting rules, but they are not enabled and ruff community collects opinions before deciding whether a rule is worth eing enabled by default.
And there are some useful rules, I'd like to start enabling them in smaller groups, to make review easier. Starting with this patch and already enabled rules.
[1] https://docs.astral.sh/ruff/preview/#preview
Pull Request Checklist