-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix log paths for subresults loaded from tmt-report-results.yaml #3370
base: main
Are you sure you want to change the base?
Conversation
c46a241
to
2b4974d
Compare
2b4974d
to
3eaaf33
Compare
3eaaf33
to
0920dba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I quickly checked the generated results.yaml
file and it does not seem to be correct. I used the following test:
cd tests/execute/restraint/report-result/data
tmt run --all test --name output report --how html --open
Seems that while the subresult logs have been fixed and are working fine the main result logs are now broken.
0920dba
to
753cd1f
Compare
Great catch @psss ! The problem is that the log path fix is applied two times - once by my changes in I've modified my changes to apply the fix in Could you (@psss @happz) please check again and help me with the testing? I do not want to break anything for the users :). Thanks! |
…se _load_tmt_report_results_file())
The result/subresult log file path loaded from the
tmt-report-results.yaml
file must be modified to be relative toexecute
directory the same way as forcustom
/restraint
results (see ExecutePlugin._process_results_partials(...)).Pull Request Checklist