-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple reportportal plugin improvements and fixes #3356
base: main
Are you sure you want to change the base?
Conversation
The problem with |
b2f5688
to
c1518ce
Compare
5c4abeb
to
ba510e2
Compare
I have just tested a plain import of a test plan with passing and failing tests and it worked well. |
Thanks for helping me with the testing! Could you please add a check to this PR that you did a review? Also, do you know anyone else who uses the ReportPortal and could us help with the testing of these changes? What about @KwisatzHaderach? |
not actually using the rp plugin, we do all our exports through data router using polarion xml |
f19af6c
to
d3fbee8
Compare
@seberm Hi Otto, we found one more issues in the RP plugin, in method def _filter_log_per_size there is the following line:
But settings.size.to('bytes').magnitude is float actually (e.g. 1000000.0) and it causes:
The fix is easy - int that, ie. replace that with:
(consulted with Karel and Milos). Since this is rather generic PR for RP plugin fixes, would it be possible to squeeze this in? |
d3fbee8
to
6477dce
Compare
This PR should fix the problem with a possible reportportal error when using
result: restraint
orresult: custom
:For more info, see:
reportportal
report plugin withcustom
results #3360This error is probably caused by the badly sorted result start times. It can happen the datetime formats in the list are not in the same format. The
Result.start_time
is in ISO format but theself.time()
returnsstr(int(time() * 1000))
.The basic reproducer
Other improvements
There are also small code improvements like the possibility to ignore the SSL verification, adding the usage of Python properties instead of class methods, or adding handling of
ResultOutcome.SKIP
outcome which I believe is missing from the mapping.TODOs:
Pull Request Checklist
ssl-verify
option