Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the when key in step phases #3340

Merged
merged 6 commits into from
Dec 11, 2024
Merged

Add support for the when key in step phases #3340

merged 6 commits into from
Dec 11, 2024

Conversation

lukaszachy
Copy link
Collaborator

@lukaszachy lukaszachy commented Nov 4, 2024 •
edited
Loading

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

@lukaszachy lukaszachy linked an issue Nov 4, 2024 that may be closed by this pull request
Allow when key for step configs #2703
Closed
@lukaszachy lukaszachy added the ci | full test Pull request is ready for the full test execution label Nov 4, 2024
@lukaszachy lukaszachy marked this pull request as ready for review November 5, 2024 10:40
@lukaszachy lukaszachy added this to the 1.39 milestone Nov 5, 2024
@lukaszachy lukaszachy added specification Metadata specification (core, tests, plans, stories) area | context The context adjust implementation labels Nov 5, 2024
thrix
thrix reviewed Nov 5, 2024
View reviewed changes
docs/releases.rst Outdated Show resolved Hide resolved
thrix
thrix reviewed Nov 5, 2024
View reviewed changes
docs/guide.rst Show resolved Hide resolved
thrix
thrix reviewed Nov 5, 2024
View reviewed changes
docs/guide.rst Show resolved Hide resolved
happz
happz reviewed Nov 5, 2024
View reviewed changes
tmt/steps/__init__.py Outdated Show resolved Hide resolved
martinhoyer
martinhoyer reviewed Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@martinhoyer martinhoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
I'm thinking if it would make sense if Phase would have a more generic enabled property, but that's just a random thought, no opinion.

docs/guide.rst Outdated Show resolved Hide resolved
spec/plans/finish.fmf Show resolved Hide resolved
@happz
Copy link
Collaborator

happz commented Nov 7, 2024

Nice! I'm thinking if it would make sense if Phase would have a more generic enabled property, but that's just a random thought, no opinion.

@martinhoyer there's definitely one situation when "enabled" needs an input, i.e. "Is this phase enabled on this guest?", and because of that I think we cannot reach a singular "Is this phase enabled?" property.

@psss psss modified the milestones: 1.39, 1.40 Nov 21, 2024
@psss psss added the priority | should medium priority, should be included in the next release label Dec 3, 2024
happz
happz reviewed Dec 3, 2024
View reviewed changes
tmt/steps/__init__.py Outdated Show resolved Hide resolved
@lukaszachy lukaszachy requested a review from happz December 10, 2024 09:44
psss
psss approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, improvement! Looks good, just the individual step schemas have not been updated. Should be fixed by 9efdd1d.

@psss psss changed the title When everywhere Add support for the when key in step phases Dec 10, 2024
@psss psss merged commit 5dc0a1f into main Dec 11, 2024
20 checks passed
@psss psss deleted the when-everywhere branch December 11, 2024 07:08
@psss psss self-assigned this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KwisatzHaderach KwisatzHaderach KwisatzHaderach approved these changes

@psss psss psss approved these changes

@martinhoyer martinhoyer martinhoyer approved these changes

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@happz happz Awaiting requested review from happz happz is a code owner

Assignees

@psss psss

Labels
area | context The context adjust implementation ci | full test Pull request is ready for the full test execution priority | should medium priority, should be included in the next release specification Metadata specification (core, tests, plans, stories)
Projects
None yet
Milestone
1.40
Development

Successfully merging this pull request may close these issues.

Allow when key for step configs
6 participants
@lukaszachy @happz @thrix @KwisatzHaderach @psss @martinhoyer