Skip to content

Set default unit of memory to MiB if none is provided #3113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

Set default unit of memory to MiB if none is provided #3113

merged 1 commit into from
Apr 16, 2025

Conversation

skycastlelily
Copy link
Collaborator

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

@skycastlelily
Copy link
Collaborator Author

Fix #3112:)

@psss psss requested a review from martinhoyer as a code owner March 12, 2025 05:10
@happz happz added this to planning Apr 3, 2025
@github-project-automation github-project-automation bot moved this to backlog in planning Apr 3, 2025
@happz happz moved this from backlog to review in planning Apr 3, 2025
@happz happz added specification Metadata specification (core, tests, plans, stories) area | hardware Implementation of hardware requirements labels Apr 4, 2025
@psss psss added this to the 1.47 milestone Apr 10, 2025
@happz
Copy link
Collaborator

happz commented Apr 11, 2025

@skycastlelily please, rebase when you find some spare time, it seems very trivial & easy to get in.

@skycastlelily
Copy link
Collaborator Author

@skycastlelily please, rebase when you find some spare time, it seems very trivial & easy to get in.

Rebased, sorry for the late response, AYK, I was on sick leaves^^

@skycastlelily skycastlelily added the ci | full test Pull request is ready for the full test execution label Apr 14, 2025
@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Apr 16, 2025
@happz happz moved this from review to merge in planning Apr 16, 2025
@psss psss changed the title Set default unit of memory to MiB if non is provided Set default unit of memory to MiB if none is provided Apr 16, 2025
psss
psss reviewed Apr 16, 2025
View reviewed changes
@psss
Copy link
Collaborator

psss commented Apr 16, 2025

Failing tests are irrelevant rawhide debuginfo errors.

@psss psss merged commit 0cc70a4 into main Apr 16, 2025
21 of 22 checks passed
@psss psss deleted the use-default branch April 16, 2025 15:19
@github-project-automation github-project-automation bot moved this from merge to done in planning Apr 16, 2025
bajertom pushed a commit that referenced this pull request Aug 11, 2025
@skycastlelily @bajertom
Set default unit of memory to MiB if none is provided (#3113)
fe335fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happz happz happz approved these changes

@psss psss psss approved these changes

@therazix therazix therazix approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy

@thrix thrix Awaiting requested review from thrix

@janhavlin janhavlin Awaiting requested review from janhavlin

@martinhoyer martinhoyer Awaiting requested review from martinhoyer

Assignees
No one assigned
Labels
area | hardware Implementation of hardware requirements ci | full test Pull request is ready for the full test execution specification Metadata specification (core, tests, plans, stories) status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
planning
Status: done
Milestone
1.47
Development

Successfully merging this pull request may close these issues.
4 participants
@skycastlelily @happz @psss @therazix