Adds "bootstrap logger" for logging before CLI options are recognized #1839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thrix
requested changes
Feb 9, 2023
janhavlin
approved these changes
Mar 2, 2023
lukaszachy
approved these changes
Mar 2, 2023
Aims at parts of tmt lifetime where logging is needed, but CLI options like --debug are unknown yet. This would be code that's executed in import time, the most visible one is plugin explocation & importing, but there may be other. At this moment, `fmf.utils.Logging` is used for this purpose, but that's tmt's logging "sneaking" away from what `tmt.log` offers and implements. And that's not good, as it may mean slightly different logging behavior than the one exhibited during the rest of tmt run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims at parts of tmt lifetime where logging is needed, but CLI options like --debug are unknown yet. This would be code that's executed in import time, the most visible one is plugin explocation & importing, but there may be other. At this moment,
fmf.utils.Loggingis used for this purpose, but that's tmt's logging "sneaking" away from whattmt.logoffers and implements. And that's not good, as it may mean slightly different logging behavior than the one exhibited during the rest of tmt run.Part of the effort behind #1838 and #216.