-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for merging list with dict #256
base: main
Are you sure you want to change the base?
Conversation
it is questionable if we really need a new operator. Can't we simply stick to |
85b055f
to
e496cd3
Compare
|
Just a thought, if we go with the |
So, after reading through the original issue it seems there are more people favoring using the I like this option more (if you want to compare both variants see the 1st commit only). Moreover, now the following use case seems to be handled as well:
|
if not isinstance(list_item, dict): | ||
"MergeError: Item '{0}' in {1} must be a dictionary.".format( | ||
list_item, self.name) | ||
self._merge_special(list_item, data[key]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, what's happening with those original something+
attributes? I mean, we do the update of the respective something
attribute but what happens with something+
. Does fmf
care about it? Does it matter if we modify it? I am asking because this code is in fact modifying the something+
element as well.
7063d16
to
dbebab8
Compare
9fc47a2
to
1bedbb5
Compare
@psss Hi, I do not plan any further updates unless requested. Please review. |
/packit retest-failed |
@psss Hi, could you please check failing tests? It doesn't seem related, rather like a change in Fedora distro that is not reflected in tests. Thank you. |
21a2155
to
97b5133
Compare
Tests failures doesn't seem to be related. Same failures were present even when I have reverted my commits. |
97b5133
to
1348565
Compare
No description provided.