Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the referencing library where available #253

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Use the referencing library where available #253

merged 3 commits into from
Dec 2, 2024

Conversation

martinhoyer
Copy link
Contributor

@martinhoyer martinhoyer commented Aug 27, 2024 •
edited by psss
Loading

Use the referencing library where available instead of deprecated jsonschema.RefResolver.

Addressing #194 .

Getting rid of deprecation warnings.

@martinhoyer martinhoyer self-assigned this Aug 27, 2024
@martinhoyer martinhoyer added utils and removed discuss labels Nov 1, 2024
@martinhoyer martinhoyer changed the title [DO NOT MERGE] Migrate from RefResolver to referencing library Use referencing library where available instead of deprecated jsonschema.RefResolver Nov 1, 2024
@martinhoyer martinhoyer marked this pull request as ready for review November 1, 2024 19:13
LecrisUT
LecrisUT suggested changes Nov 3, 2024
View reviewed changes
fmf.spec Outdated Show resolved Hide resolved
fmf/_compat_jsonschema.py Outdated Show resolved Hide resolved
fmf/_compat_jsonschema.py Outdated Show resolved Hide resolved
fmf/_compat_jsonschema.py Outdated Show resolved Hide resolved
fmf/_compat_jsonschema.py Outdated Show resolved Hide resolved
fmf/_compat_jsonschema.py Outdated Show resolved Hide resolved
fmf/_compat_jsonschema.py Outdated Show resolved Hide resolved
fmf/utils.py Outdated Show resolved Hide resolved
fmf/utils.py Show resolved Hide resolved
@psss psss added this to the 1.5 milestone Nov 26, 2024
@happz
Copy link
Collaborator

happz commented Nov 26, 2024

So many distinct changes squashed into a single PR :(

@martinhoyer
Copy link
Contributor Author

So many distinct changes squashed into a single PR :(

Well, I couldn't run pre-commit without it and didn't want to make workarounds.

@martinhoyer
Copy link
Contributor Author

martinhoyer commented Nov 26, 2024 •
edited
Loading

...but fwiw, for there is a pr for the last commit #258

Context for the autopep8 is that the previous hook repo was unmaintained and stopped being updated (doesn't work at all on py3.13). Replaced it with what was recommended as replacement and with --strict, the is_instance changes were needed to pass that check.

@martinhoyer martinhoyer requested a review from LecrisUT November 26, 2024 12:17
@martinhoyer
Copy link
Contributor Author

And of course I have a typo in commit message refferencing -> referencing.

LecrisUT
LecrisUT reviewed Nov 27, 2024
View reviewed changes
fmf/utils.py Outdated Show resolved Hide resolved
fmf/utils.py Outdated Show resolved Hide resolved
fmf/_compat_jsonschema.py Outdated Show resolved Hide resolved
@psss
Copy link
Collaborator

psss commented Nov 29, 2024

So many distinct changes squashed into a single PR :(

Well, I couldn't run pre-commit without it and didn't want to make workarounds.

Let's address at least the pre-commit changes separately in #259?

@martinhoyer martinhoyer requested a review from LecrisUT November 30, 2024 15:30
psss
psss requested changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this! Looks good, just a few minor comments.

.gitignore Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
fmf/utils.py Outdated Show resolved Hide resolved
@psss psss linked an issue Dec 2, 2024 that may be closed by this pull request
Replace jsonschema.RefResolver as is being deprecated #194
Closed
@psss psss changed the title Use referencing library where available instead of deprecated jsonschema.RefResolver Use the referencing library where available Dec 2, 2024
@psss
Copy link
Collaborator

psss commented Dec 2, 2024

/packit build

@psss psss merged commit b439fc8 into teemtee:main Dec 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LecrisUT LecrisUT LecrisUT approved these changes

@psss psss psss approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@happz happz Awaiting requested review from happz happz is a code owner

Assignees

@martinhoyer martinhoyer

Labels
packaging utils
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

Replace jsonschema.RefResolver as is being deprecated
4 participants
@martinhoyer @happz @psss @LecrisUT