-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
print newest deps #2792
base: master
Are you sure you want to change the base?
print newest deps #2792
Conversation
Thanks for this patch. I think overall it's good to surface this information, but the way it's presented in this implementation is not particularly clear. Simply saying There's also a couple technical issues with it; for one it removes Also it appears to bring in a new dependency, which causes a lot of extra work for downstream packagers. As far as I can tell, this is only being used for a single function, which duplicates logic already available from Aether: https://github.com/technomancy/leiningen/blob/master/leiningen-core/src/leiningen/core/pedantic.clj#L68 Let's use the existing implementation instead of bringing in something redundant. |
According to you suggestion, I make some modifications. |
Sorry, I haven't gotten a chance to look at this yet, but I don't think it needs to be closed. Was that intentional? |
II'd like to think about this modification again. I think there are still some problems, but you can also take a look at it first and suggest some changes. |
I will make some fixes. |
Fix is completed. |
When conflict deps found, print the depency of newest version.