Allow using Session
instead of Engine
#56
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is yet another change adapted from Woodpecker's migrator:
Instead of using
xorm.Engine
as arguments for the migration functions, usexorm.Session
. The reason for this is that you can rollback sessions if the migration fails, so nothing should be changed.This change is breaking though, you'd need to change every migration func. Thus, feel free to close this if you don't like it.