Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geolocate User, and Persist Zip to URL #30

Closed
wants to merge 2 commits into from
Closed

Conversation

jlev
Copy link
Contributor

@jlev jlev commented Oct 4, 2019

For #24 and #20

- adds zip to browser history
- checks for search param on first render, for sharing
- persists to searchBar via props
- browser geolocation on demand (requires https)
@jlev jlev changed the base branch from master to staging October 4, 2019 18:51
@jlev
Copy link
Contributor Author

jlev commented Oct 4, 2019

switched base to staging to reflect new process. will file separate PRs per issue ticket in the future...

@jasonkalmeida
Copy link
Collaborator

Regarding #24 - @mick will this come into conflict with your current viewport/region scope implementation?

@mick
Copy link

mick commented Oct 5, 2019

re #24 We should pick either zipcode in the url or center of the map in the url. keeping the center of map allows for panning around and then sharing that current view. We could make zipcode an optional param to initially center the map.

re geolocation we won't need to reverse geocode anything. Just center the map.

@jlev
Copy link
Contributor Author

jlev commented Oct 8, 2019

Ok, it looks like Mick's Mapbox GL branch is the direction we're going (assuming we've resolved outstanding issues in #25).

I'll close this and open a new PR with the geolocation functionality in a button (along with zoom in/out, which right now is hidden). Can also pop that on load for mobile devices, if that's desired in situations where we don't already have a viewport set in the URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants