Show all events Leaflet - Frontend #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we can fetch all events quickly on load with PR #27 Let's display them all on the map. This PR isnt meant to be merged Its just a quick pass at what map with all events looks like, and if leaflet will be able to handle this number of custom markers.
It's great to see all the events across the Map. But you'll notice if/when you run this the map is SLOW. Leaflet + custom markers + a lot of events makes the interaction super slow, basically unusable.
I see we already need to figure out switching map tile providers in #25 This is another good reason to upgrade to mapbox-gl with that switch.
cc @jasonkalmeida