Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web Accessibility (WCAG 2.1) #23

Open
danielnarey opened this issue Sep 20, 2019 · 1 comment
Open

Web Accessibility (WCAG 2.1) #23

danielnarey opened this issue Sep 20, 2019 · 1 comment

Comments

@danielnarey
Copy link

We have a couple volunteers who are knowledgeable about how to improve user experience for people with disabilities, including users of screen readers and other assistive technology. I have asked them to take a look at the current prototype and contribute here.
@john-osullivan
Copy link
Contributor

There's an automatic tester which can let us know about basic things! Here's the current report from it: https://wave.webaim.org/report#/https://techforwarren.github.io/eventmap

eostrom added a commit to eostrom/eventmap that referenced this issue Oct 21, 2019
@eostrom
Search bar accessibility improvements.
1958d34 
- all inputs should have labels
  - eliminated placeholder, which should only be used for examples
  - simulated placeholder interaction (disappear on input)
  - for usability, I don't think we should hide the label, but I'm
    not trying to redesign here
- focus highlight for locate button now surrounds the whole icon
  - this shifts the button's position slightly but I think it's fine
- added alt text to locate icon

Also removed `console.log` which probably shouldn't be in production.

This fixes some of the low-hanging WCAG fruit (techforwarren#23).
@eostrom eostrom mentioned this issue Oct 21, 2019
Merged
eostrom added a commit to eostrom/eventmap that referenced this issue Oct 21, 2019
@eostrom
Search bar accessibility improvements.
e4c471b 
- all inputs should have labels
  - eliminated placeholder, which should only be used for examples
  - simulated placeholder interaction (disappear on input)
  - for usability, I don't think we should hide the label, but I'm
    not trying to redesign here
- focus highlight for locate button now surrounds the whole icon
  - this shifts the button's position slightly but I think it's fine
- added alt text to locate icon

Also removed `console.log` which probably shouldn't be in production.

This fixes some of the low-hanging WCAG fruit (techforwarren#23).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@john-osullivan @danielnarey