Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BE/#299 구인 게시글에 조회수 기능 추가 #300

Merged
merged 3 commits into from
Nov 17, 2023
Merged

BE/#299 구인 게시글에 조회수 기능 추가 #300

merged 3 commits into from
Nov 17, 2023

Conversation

youKeon
Copy link
Collaborator

@youKeon youKeon commented Nov 16, 2023 •
edited
Loading

🛠️ 변경사항



☝️ 유의사항



👀 참고자료



❗체크리스트

  • 하나의 메소드는 최소의 기능만 하도록 설정했나요?
  • 수정 가능하도록 유연하게 작성했나요?
  • 필요 없는 import문이나 setter 등을 삭제했나요?
  • 기존의 코드에 영향이 없는 것을 확인하였나요?

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 16, 2023 •
edited
Loading

Unit Test Results

85 tests  ±0   85 ✔️ ±0   3s ⏱️ -2s
17 suites ±0     0 💤 ±0 
17 files   ±0     0 ❌ ±0 

Results for commit 1ef1a80. ± Comparison against base commit 1e1fc73.

♻️ This comment has been updated with latest results.

kimhalin
kimhalin approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@kimhalin kimhalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다! 중복되는 부분이 많아 보여서 후에 조회수 관련 함수들은 global로 빼서 리팩토링 하는 것도 고려해봐야겠네용

baekhangyeol
baekhangyeol approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@baekhangyeol baekhangyeol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@youKeon youKeon merged commit 9a8b1c3 into feature Nov 17, 2023
@youKeon youKeon deleted the BE/#299 branch November 17, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimhalin kimhalin kimhalin approved these changes

@baekhangyeol baekhangyeol baekhangyeol approved these changes

Assignees
No one assigned
Labels
기능구현
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@youKeon @kimhalin @baekhangyeol