Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : 사용자 닉네임으로 마이 페이지 조회 기능 구현 #275

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

youKeon
Copy link
Collaborator

@youKeon youKeon commented Oct 12, 2023

🛠️ 변경사항

  • 유저 이름으로 조회하는 마이페이지 API
  • 마이페이지, 유저 조회 API 인가 요청 X
  • 마이페이지 응답 DTO 한 줄 소개를 글 본문 내용으로 변경


☝️ 유의사항



👀 참고자료



❗체크리스트

  • 하나의 메소드는 최소의 기능만 하도록 설정했나요?
  • 수정 가능하도록 유연하게 작성했나요?
  • 필요 없는 import문이나 setter 등을 삭제했나요?
  • 기존의 코드에 영향이 없는 것을 확인하였나요?

@github-actions
Copy link

github-actions bot commented Oct 12, 2023

Unit Test Results

85 tests  ±0   85 ✔️ ±0   6s ⏱️ +2s
17 suites ±0     0 💤 ±0 
17 files   ±0     0 ±0 

Results for commit e064f7d. ± Comparison against base commit d22b165.

♻️ This comment has been updated with latest results.

@@ -124,6 +126,12 @@ public GetMyPageResponse myPage(Member member) {
return GetMyPageResponse.of(member, projectInfoList);
}

public GetMyPageResponse myPageByNickname(String nickname) {
Member member = memberService.findMemberByNickname(nickname);
List<GetProjectInfoResponse> projectInfoList = this.findProjectInfoList(member.getId());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

미처 못 봤었는데 이것도 페이징이 필요할 것 같은 생각이 드네요..! 급한 건이라 들어서 일단 approve 하겠습니다

@youKeon youKeon merged commit bf65c62 into feature Oct 12, 2023
3 checks passed
@youKeon youKeon deleted the BE/#274 branch October 12, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants