Fe/#243 ReadingPage 및 GptModal, Reply, QuillWritten, ReadReply, ReadReReply, WritingReReply, PutReReply 컴포넌트 마이그레이션 #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- API 호출 방식 변경 : axiox -> fetch
- react quill -> toast ui 라이브러리 변경 - QuillWritten -> ToastViewer 이름 변경
Mayreeel
reviewed
Oct 12, 2023
| import nested_reply from '../../../public/images/svg/nested_reply.svg' | ||
| import pencil_square from '../../../public/images/svg/pencil-square.svg' | ||
| import { refreshState } from '../../utils/atoms' | ||
| // TODO: import useDidMountEffect from '../../../../useDidMountEffect' |
There was a problem hiding this comment.
useDidMountEffect는 hooks 폴더 안에 있어서 가져다가 쓰시면 될 것 같습니다!
| import { useRecoilState, useRecoilValue } from 'recoil' | ||
| import gptIcon from '../../../../../public/images/svg/gptIcon.svg' | ||
| import ProfileIcon from '../../../../../public/images/svg/profileIcon.svg' | ||
| // TODO: import NavBar from '../../components/general/NavBar' |
There was a problem hiding this comment.
NavBar는 layout.tsx 파일에서 한번에 관리해서 아예 빼셔도 될 것 같아요!
There was a problem hiding this comment.
넵 감사합니다! 다른 파일들에서도 모두 뺐습니다 😄
There was a problem hiding this comment.
혹시 제가 이미 추가 했던 파일인데 또 추가되는 이유가 있을까요??
There was a problem hiding this comment.
아 머지되기 전 브랜치라 추가했었습니다! 😅
지금은 다시 제거했습니다
| @@ -0,0 +1,263 @@ | |||
| 'use client' | |||
|
|
|||
| import { act } from '@testing-library/react' | |||
There was a problem hiding this comment.
마이그레이션 후 React-Testing-Library로 테스팅은 안하고 있으니 일단 빼셔도 될 것 같습니다!
| @@ -0,0 +1,130 @@ | |||
| 'use client' | |||
|
|
|||
| import { act } from '@testing-library/react' | |||
| @@ -17,7 +17,7 @@ type DataObject = { | |||
| thumbNail: string | |||
| } | |||
|
|
|||
| type ParamsType = { | |||
| export type ParamsType = { | |||
There was a problem hiding this comment.
혹시 이거 export해서 어디다가 가져다 쓰시는 건가요??..
There was a problem hiding this comment.
아 지금은 사용하는 곳이 없어서 빼야겠네요
감사합니당 😊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ 변경사항
GptModal, ReadReply, ReadReReply, WritingReReply, 컴포넌트
Reply, PutReply 컴포넌트
QuillWritten 컴포넌트
☝️ 유의사항
👀 참고자료
❗체크리스트