Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be/#261 채용공고 목록 조회 기능 구현 #267

Merged
merged 5 commits into from
Oct 10, 2023
Merged

Conversation

baekhangyeol
Copy link
Collaborator

🛠️ 변경사항

스크린샷 2023-10-07 오후 9 40 16

createAt 컬럼이 아닌 expiration_date로 정렬이 되어야하기 때문에, 그에 맞게 PageRequest에 jobOf 추가

☝️ 유의사항

👀 참고자료

❗체크리스트

  • 하나의 메소드는 최소의 기능만 하도록 설정했나요?
  • 수정 가능하도록 유연하게 작성했나요?
  • 필요 없는 import문이나 setter 등을 삭제했나요?
  • 기존의 코드에 영향이 없는 것을 확인하였나요?

@github-actions
Copy link

github-actions bot commented Oct 7, 2023

Unit Test Results

85 tests   - 3   85 ✔️  - 3   4s ⏱️ -1s
17 suites  - 2     0 💤 ±0 
17 files    - 2     0 ±0 

Results for commit f3c591c. ± Comparison against base commit 17182de.

This pull request removes 3 tests.
com.graphy.backend.domain.job.controller.JobControllerTest ‑ 공고를 삭제한다.
com.graphy.backend.domain.job.controller.JobControllerTest ‑ 공고를 저장한다.
com.graphy.backend.domain.job.service.JobServiceTest ‑ 공고가 삭제된다.

♻️ This comment has been updated with latest results.

@baekhangyeol baekhangyeol linked an issue Oct 7, 2023 that may be closed by this pull request
2 tasks
Copy link
Collaborator

@youKeon youKeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! LGTM!!

@baekhangyeol baekhangyeol merged commit d22b165 into feature Oct 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] 채용공고 목록 조회 기능 구현
2 participants