BE/#257 프로젝트 목록 조회 시 검색이 제대로 되지 않는 오류 수정 #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ 변경사항
PageRequest의 size가 0보다 작을 경우 예외처리 추가
GlobalExceptionHandler에 잘못된 클래스가 추가되어 있어 수정했습니다!
검색이 제대로 되지 않던 이유는 GetProjectsRequest에 Setter가 없어 쿼리 파라미터로 가져오지 못하고 있었습니다(이 dto 클래스에만 예외적으로 setter를 추가해놓겠습니다).. 그래서 검색 조건들이 다 null로 들어가고 있어 조회가 제대로 되지 않았어요
☝️ 유의사항
👀 참고자료
❗체크리스트