Skip to content

PAC-950 Add compatibility with PHP 8.4 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

PAC-950 Add compatibility with PHP 8.4 #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a30bed8
PAC-950 Add compatibility with PHP 8.4
svizevv Sep 18, 2025
4464825
PAC-950 Update dependencies
svizevv Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
# Version 2.1.0

## Features

### PHP 8.4 Compatibility

* Add PHP 8.4 support

# Version 2.0.0

### PHP 8.1 Compatibility
Expand Down Expand Up @@ -31,4 +39,4 @@

## Features

* PAC-541: Update composer with php Version ">=^7.3"
* PAC-541: Update composer with php Version ">=^7.3"
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"prefer-stable": true,
"require": {
"php": "^8.1",
"techdivision/import-serializer": "^2.0.0"
"techdivision/import-serializer": "^2.1"
},
"require-dev": {
"doctrine/dbal": "^4.0.4",
Expand All @@ -33,4 +33,4 @@
]
}
}
}
}
6 changes: 3 additions & 3 deletions src/AdditionalAttributeCsvSerializer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ public function unserialize($serialized = null, $delimiter = null)
* @return string The serialized array
* @see \TechDivision\Import\Serializer\SerializerInterface::serialize()
*/
public function serialize(array $unserialized = null, $delimiter = null)
public function serialize(?array $unserialized = null, $delimiter = null)
{
return $this->getValueCsvSerializer()->implode($unserialized, $delimiter ? $delimiter : $this->getMultipleFieldDelimiter());
}
Expand Down Expand Up @@ -319,7 +319,7 @@ public function explode($value = null, $delimiter = null)
* @return string|null The compatected value
* @see \TechDivision\Import\Serializer\SerializerInterface::serialize()
*/
public function implode(array $value = null, $delimiter = null)
public function implode(?array $value = null, $delimiter = null)
{
return $this->serialize($value, $delimiter);
}
Expand All @@ -332,7 +332,7 @@ public function implode(array $value = null, $delimiter = null)
*
* @return array The array with the denormalized attribute values
*/
public function denormalize(string $value = null, bool $unpack = true) : array
public function denormalize(?string $value = null, bool $unpack = true) : array
{

// initialize the array for the attributes
Expand Down
4 changes: 2 additions & 2 deletions src/CategoryCsvSerializer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ public function explode($value = null, $delimiter = null)
* @return string|null The compatected value
* @see \TechDivision\Import\Serializer\SerializerInterface::serialize()
*/
public function implode(array $value = null, $delimiter = null)
public function implode(?array $value = null, $delimiter = null)
{
return $this->serialize($value, $delimiter);
}
Expand Down Expand Up @@ -195,7 +195,7 @@ public function unserialize($serialized = null, $delimiter = null)
* @return string The serialized array
* @see \TechDivision\Import\Serializer\SerializerInterface::serialize()
*/
public function serialize(array $unserialized = null, $delimiter = null)
public function serialize(?array $unserialized = null, $delimiter = null)
{
return $this->getValueCsvSerializer()->implode($unserialized, $delimiter ? $delimiter : $this->getCategoryDelimiter());
}
Expand Down
4 changes: 2 additions & 2 deletions src/ProductCategoryCsvSerializer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ public function explode($value = null, $delimiter = null)
* @return string|null The compatected value
* @see \TechDivision\Import\Serializer\SerializerInterface::serialize()
*/
public function implode(array $value = null, $delimiter = null)
public function implode(?array $value = null, $delimiter = null)
{
return $this->serialize($value, $delimiter);
}
Expand Down Expand Up @@ -195,7 +195,7 @@ public function unserialize($serialized = null, $delimiter = null)
* @return string The serialized array
* @see \TechDivision\Import\Serializer\SerializerInterface::serialize()
*/
public function serialize(array $unserialized = null, $delimiter = null)
public function serialize(?array $unserialized = null, $delimiter = null)
{
return $this->getValueCsvSerializer()->implode($unserialized, $delimiter);
}
Expand Down
4 changes: 2 additions & 2 deletions src/ValueCsvSerializer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ protected function getDelimiter()
*
* @return string The serialized array
*/
public function serialize(array $unserialized = null, $delimiter = null)
public function serialize(?array $unserialized = null, $delimiter = null)
{

// do nothing, if the passed value is empty or NULL
Expand Down Expand Up @@ -153,7 +153,7 @@ public function explode($value = null, $delimiter = null)
* @return string|null The compatected value
* @see \TechDivision\Import\Serializer\SerializerInterface::serialize()
*/
public function implode(array $value = null, $delimiter = null)
public function implode(?array $value = null, $delimiter = null)
{

// set the delimiter
Expand Down
Loading