Add dynamic "next meetup" to home page #33

iLtc · 2017-02-11T22:13:09Z

This pull request tries to resolve #27 .

Note: The javascript code, include the api signature, modify from _includes/meetup_cards.html .

We can also:

Add event description to the alt attribute
Change date format
Change link style
Move the javascript code to a separate file

Merge pull request techcorridorio#32 from iLtc/master

So that I can get the code back~ This reverts commit cfc403a.

benjaminoakes · 2017-02-14T21:27:39Z

index.html

+
+    // Modify from _includes/meetup_cards.html 
+
+    window.onload = function(){


This should probably use $(document).ready(function ...) (or just $(function ...))

I cannot use $(document).ready(function ...) here since jQuery will be imported after this code. Would you mind if I move <script src="//ajax.googleapis.com/ajax/libs/jquery/1.11.2/jquery.min.js"></script> to <head>?

benjaminoakes · 2017-02-14T21:28:24Z

index.html

@@ -28,3 +29,53 @@
        </div>
    </div>
 </div>
+
+{% raw  %}
+<script type="text/javascript">


It might be nice to have this in a separate .js file.

I moved most of the js code to js/meetup-events.js but left the trigger code here.

benjaminoakes · 2017-02-14T21:28:29Z

index.html

@@ -28,3 +29,53 @@
        </div>
    </div>
 </div>
+
+{% raw  %}


Is this necessary?

I removed it.

benjaminoakes · 2017-02-14T21:28:55Z

index.html

+    //assume Mustache is loaded
+    //assume Meetup is loaded
+
+    // Modify from _includes/meetup_cards.html 


Can we refactor that code so it's reusable without copying and pasting?

I moved all the js code to js/meetup-events.js. If you want, I can refactor _includes/meetup_cards.html and _includes/developers_cards.html so they share the same code file.

benjaminoakes · 2017-02-14T21:29:29Z

This is exactly what I was hoping for, but we should probably clean up the code a little before merging.

houndci-bot · 2018-03-13T03:14:37Z

js/meetup-events.js

+};
+
+var createEventParagraph = function (event) {
+    var template = "Next meetup: <a href='{{event_url}}' target='_blank'>{{name}} ({{formattedShortDate}})</a>";


Line is too long.
Mixed double and single quotes.

houndci-bot · 2018-03-13T03:14:38Z

js/meetup-events.js

+            + (date.getHours() % 12) + ':'
+            + (date.getMinutes() < 10 ? '0'+date.getMinutes() : date.getMinutes())
+            + ' '
+            + (date.getHours() < 12 ? 'AM' : 'PM');


Misleading line break before '+'; readers may interpret this as an expression boundary.

houndci-bot · 2018-03-13T03:14:38Z

js/meetup-events.js

+            + ' at '
+            + (date.getHours() % 12) + ':'
+            + (date.getMinutes() < 10 ? '0'+date.getMinutes() : date.getMinutes())
+            + ' '


Misleading line break before '+'; readers may interpret this as an expression boundary.

houndci-bot · 2018-03-13T03:14:38Z

js/meetup-events.js

+            + date.getFullYear()
+            + ' at '
+            + (date.getHours() % 12) + ':'
+            + (date.getMinutes() < 10 ? '0'+date.getMinutes() : date.getMinutes())


Line is too long.
Misleading line break before '+'; readers may interpret this as an expression boundary.

houndci-bot · 2018-03-13T03:14:38Z

js/meetup-events.js

+            + date.getDate() + ', '
+            + date.getFullYear()
+            + ' at '
+            + (date.getHours() % 12) + ':'


Misleading line break before '+'; readers may interpret this as an expression boundary.

houndci-bot · 2018-03-13T03:14:38Z

js/meetup-events.js

+    var months = [
+        "January", "February", "March", "April",
+        "May", "June", "July", "August",
+        "September", "October", "November", "December"


Mixed double and single quotes.

houndci-bot · 2018-03-13T03:14:38Z

js/meetup-events.js

+    var day = [ "Sunday", "Monday", "Tuesday", "Wednesday", "Thursday", "Friday", "Saturday"];
+    var months = [
+        "January", "February", "March", "April",
+        "May", "June", "July", "August",


Mixed double and single quotes.

houndci-bot · 2018-03-13T03:14:38Z

js/meetup-events.js

+
+    var day = [ "Sunday", "Monday", "Tuesday", "Wednesday", "Thursday", "Friday", "Saturday"];
+    var months = [
+        "January", "February", "March", "April",


Mixed double and single quotes.

houndci-bot · 2018-03-13T03:14:38Z

js/meetup-events.js

+        return "http://maps.google.com/?q=" + encodeURI(venue.address_1) + '+' + encodeURI(venue.city);
+    };
+
+    var day = [ "Sunday", "Monday", "Tuesday", "Wednesday", "Thursday", "Friday", "Saturday"];


Line is too long.
Mixed double and single quotes.

houndci-bot · 2018-03-13T03:14:39Z

js/meetup-events.js

+
+var EventPresenter = function(event) {
+    var formatVenueLink = function(venue) {
+        return "http://maps.google.com/?q=" + encodeURI(venue.address_1) + '+' + encodeURI(venue.city);


Line is too long.
Mixed double and single quotes.
Identifier 'address_1' is not in camel case.

houndci-bot · 2018-03-13T03:31:31Z

js/meetup-events.js

+    return event;
+};
+
+var createEventParagraph = function (event) {


'createEventParagraph' is defined but never used.

houndci-bot · 2018-03-13T03:31:31Z

js/meetup-events.js

@@ -36,3 +36,50 @@ var Meetup = function(meetupURL) {
 		});
 	};
 };
+
+var EventPresenter = function(event) {


'EventPresenter' is defined but never used.

houndci-bot · 2018-03-13T03:31:31Z

js/meetup-events.js

+    var template = 'Next meetup: <a href=\'{{event_url}}\' target=\'_blank\'>' +
+		           '{{name}} ({{formattedShortDate}})</a>';
+    Mustache.parse(template);   // optional, speeds up future uses
+    var rendered = Mustache.render(template, event);


'Mustache' is not defined.

houndci-bot · 2018-03-13T03:31:31Z

js/meetup-events.js

+var createEventParagraph = function (event) {
+    var template = 'Next meetup: <a href=\'{{event_url}}\' target=\'_blank\'>' +
+		           '{{name}} ({{formattedShortDate}})</a>';
+    Mustache.parse(template);   // optional, speeds up future uses


'Mustache' is not defined.

houndci-bot · 2018-03-13T03:31:31Z

js/meetup-events.js

+			   '+' + encodeURI(venue.city);
+    };
+
+    var day = [ 'Sunday', 'Monday', 'Tuesday', 'Wednesday', 'Thursday', 'Friday', 'Saturday'];


Line is too long.

iLtc · 2018-03-13T03:44:19Z

Sorry for the delay. I hope it was not too late.

It is a little bit difficult to solve all the problems raised by HoundCI. For example, Mustache is defined in another file. I am not sure how to fix it here.

Let me know what you think~

iLtc added 4 commits February 11, 2017 15:30

Merge pull request #1 from techcorridorio/master

239fc2a

Merge pull request techcorridorio#32 from iLtc/master

Revert "Revert "Add dynamic "next meetup" to home page""

eab0b7b

So that I can get the code back~ This reverts commit cfc403a.

Remove debug code

0fb041e

Add date to the link text

e71a23a

benjaminoakes reviewed Feb 14, 2017

View reviewed changes

iLtc added 3 commits March 12, 2018 21:40

Merge remote-tracking branch 'upstream/master'

5189c44

Merge branch 'master' into next-meetup

948be99

Moved JS Code to meetup-events.js

0831c50

houndci-bot reviewed Mar 13, 2018

View reviewed changes

iLtc added 2 commits March 12, 2018 22:24

Moved '+' to the end of the line

a59a1b0

Changed ' to "

46cb714

houndci-bot reviewed Mar 13, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add dynamic "next meetup" to home page #33

Add dynamic "next meetup" to home page #33

iLtc commented Feb 11, 2017

benjaminoakes Feb 14, 2017

iLtc Mar 13, 2018

benjaminoakes Feb 14, 2017

iLtc Mar 13, 2018

benjaminoakes Feb 14, 2017

iLtc Mar 13, 2018

benjaminoakes Feb 14, 2017

iLtc Mar 13, 2018

benjaminoakes commented Feb 14, 2017

houndci-bot Mar 13, 2018

houndci-bot Mar 13, 2018

houndci-bot Mar 13, 2018

houndci-bot Mar 13, 2018

houndci-bot Mar 13, 2018

houndci-bot Mar 13, 2018

houndci-bot Mar 13, 2018

houndci-bot Mar 13, 2018

houndci-bot Mar 13, 2018

houndci-bot Mar 13, 2018

houndci-bot Mar 13, 2018

houndci-bot Mar 13, 2018

houndci-bot Mar 13, 2018

houndci-bot Mar 13, 2018

houndci-bot Mar 13, 2018

iLtc commented Mar 13, 2018


		// Modify from _includes/meetup_cards.html

		window.onload = function(){

Add dynamic "next meetup" to home page #33

Are you sure you want to change the base?

Add dynamic "next meetup" to home page #33

Conversation

iLtc commented Feb 11, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benjaminoakes commented Feb 14, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iLtc commented Mar 13, 2018