Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events page updated #4

Open
wants to merge 3 commits into
base: master-readable
Choose a base branch
from

Conversation

Ramnath2001
Copy link
Collaborator

Updated Events page

@Ramnath2001 Ramnath2001 marked this pull request as draft May 15, 2022 15:08
@Ramnath2001 Ramnath2001 marked this pull request as ready for review May 15, 2022 15:08
@Ramnath2001 Ramnath2001 reopened this May 15, 2022
@Ramnath2001
Copy link
Collaborator Author

@Lalith18 can you please test the event page code. I have implemented snap scrolling feature as well so check that out too.

@Shanki5 Shanki5 requested a review from Lalith18 May 19, 2022 14:46
@Lalith18
Copy link
Contributor

@Ramnath2001 I checked the code. The design and functionality of the events page are implemented precisely how we wanted it to be. The code is clean and the snap scrolling feature also looks good.
I've implemented the sliding animation for past events in the techclubssn:l_pastevents branch. Let me know what you think about trying it here. Also, it would be great if you could add some spacing between the sections for the mobile view.

@Ramnath2001
Copy link
Collaborator Author

@Lalith18 I checked the new past events section and it looks much better.
Lets go with this one for the events page.

@Ramnath2001
Copy link
Collaborator Author

@Lalith18 I have updated the past events section. Check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants