feat: ci-cd 설정 #2
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pilyang
reviewed
Sep 23, 2024
.github/workflows/cd.yml
Outdated
Comment on lines
18
to
21
| - name: Set up Go | ||
| uses: actions/setup-go@v2 | ||
| with: | ||
| go-version: 1.22.5 |
There was a problem hiding this comment.
잘 몰라서 하는 질문일 수 있음!!
배포 워크플로우랑, 도커파일 확인결과 고랭 코드 빌드는 도커 이미지에서 하게 되고, 해당 깃헙 액션 워커는 소스코드 빌드등의 작동을 안하는것같은데, 이러면 해당 setup go 부분은 필요가 없는것같아용
There was a problem hiding this comment.
작업하던 브랜치 말고 이전꺼에서 갖고와서 그런가 중구난방이네욥ㅠ
Comment on lines
+3
to
+5
| on: | ||
| push: | ||
| branches: [ "main" ] |
There was a problem hiding this comment.
테스트 할 수 있는 꿀팁!!
Suggested change
| on: | |
| push: | |
| branches: [ "main" ] | |
| on: | |
| push: | |
| branches: | |
| - main | |
| - chore/ci-cd |
위처럼 해두면 이거 테스트한다고 계속 main에 머지해보고 할 필요 없이 해당 브렌치에 테스트로 계속 푸시해보면서 해당 워크플로우 동작시켜서 배포 테스트 할 수 있어용
테스트 다 되고 마지막에 이거 머지시키기 전에 해당부분 -chore/ci-cd 부분 제거하고 머지시키면 되고용
Comment on lines
+3
to
+18
| FROM golang:1.22.5 | ||
|
|
||
| # Set destination for COPY | ||
| WORKDIR /app | ||
|
|
||
| # Download Go modules | ||
| COPY go.mod go.sum ./ | ||
| RUN go mod download | ||
|
|
||
| # Copy the source code. Note the slash at the end, as explained in | ||
| # https://docs.docker.com/reference/dockerfile/#copy | ||
| COPY *.go ./ | ||
|
|
||
| # Build | ||
| RUN CGO_ENABLED=0 GOOS=linux go build -o /techbloghub-server | ||
|
|
There was a problem hiding this comment.
그 스테이지라고 하던가 분리해서 빌드용 배포용 베이스 이미지 다르게 하는것도 후에 찾아보면 좋을듯?
일단 위에서 내가 코멘트 남긴것처럼 해당 브렌치에서 배포 동작시켜보고 배포 잘 되는거 확인 된 다음에 도커 이미지파일 수정해가면서 잘 되나 안되나 테스트 하는 방향으로?
나중에 나도 어케하나 더 찾아보게되면 코멘트로 추가 남기거나 디코에 올려둠요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
더 늦어질 것 같아서 일단 PR 생성부터~!