Fixes #413 - Issue with reduce an packed columns

techascent · Sep 12, 2024 · 877c7eb · 877c7eb
1 parent 07a31c7
commit 877c7eb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/deps.edn b/deps.edn
@@ -1,6 +1,6 @@
 {:paths ["src" "resources" "target/classes"]
  :deps {;;org.clojure/clojure {:mvn/version "1.11.1"}
-        cnuernber/dtype-next {:mvn/version "10.115"}
+        cnuernber/dtype-next {:mvn/version "10.116-SNAPSHOT"}
         techascent/tech.io {:mvn/version "4.31"
                             :exclusions [org.apache.commons/commons-compress]}
         org.apache.datasketches/datasketches-java {:mvn/version "4.2.0"}

diff --git a/test/tech/v3/dataset_test.clj b/test/tech/v3/dataset_test.clj
@@ -1755,6 +1755,12 @@
     (is (= (range 5)
            (bitmap/->random-access (ds/missing subcol))))))
 
+
+(deftest issue-413-reduction-on-instant-column
+  (let [ds (ds/->dataset {:x (range 5)
+                          :y (repeatedly 5 #(java.time.Instant/now))})]
+    (is (= 3 (count (into [] (take 3) (:y ds)))))))
+
 (comment
   (require '[criterium.core :as crit])
   (def data (vec (repeatedly 100000 (fn [] {:a (rand-int 20) :b (rand) :c (rand)}))))