Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[๐Ÿ”€ merge] [2์ฐจ] ์ฝ”๋“œ ๋ฆฌํŽ™ํ† ๋ง ์‚ฌํ•ญ ์ ์šฉ (3) #135

Merged
merged 20 commits into from
Sep 11, 2024
Merged

[๐Ÿ”€ merge] [2์ฐจ] ์ฝ”๋“œ ๋ฆฌํŽ™ํ† ๋ง ์‚ฌํ•ญ ์ ์šฉ (3) #135

merged 20 commits into from
Sep 11, 2024

Conversation

junggyo1020
Copy link
Contributor

๐Ÿ“„ Work Description

๐Ÿ’ฌ To Reviewers

[2์ฐจ ์Šคํ”„๋ฆฐํŠธ] ์ฝ”๋“œ ๋ฆฌํŽ™ํ† ๋ง ์‚ฌํ•ญ์„ ๋ฐฐํฌํ•˜๊ธฐ ์ „, ํ…Œ์ŠคํŠธ๋ฅผ ํ•˜๊ธฐ ์œ„ํ•ด ์Šคํ…Œ์ด์ง• ์„œ๋ฒ„๋กœ ์ฝ”๋“œ๋ฅผ ๋จธ์ง€ํ•˜๋Š” ์ž‘์—…์„ ์ง„ํ–‰ํ•ฉ๋‹ˆ๋‹ค.

JungYoonShin and others added 20 commits September 6, 2024 23:52
@JungYoonShin
[โ™ป๏ธrefactor/#127]: grade enum key๊ฐ’ ํƒ€์ž… String์œผ๋กœ ๋ณ€๊ฒฝ
a6c5638
@JungYoonShin
[โ™ป๏ธrefactor/#127]: WorkingPeriod enum key๊ฐ’ ํƒ€์ž… String์œผ๋กœ ๋ณ€๊ฒฝ
8a91200
@JungYoonShin
[๐Ÿ“file/#127]: ํ•„ํ„ฐ๋ง ์žฌ์„ค์ • request dto๋ช… ๋ณ€๊ฒฝ
45c94c0
@JungYoonShin
[๐Ÿ“file/#127]: ์‚ฌ์šฉ์ž ํ•„ํ„ฐ๋ง ์ •๋ณด response dto๋ช… ๋ณ€๊ฒฝ
368e914
@JungYoonShin
[โ™ป๏ธrefactor/#127]: UserFilterDetailResponseDto @builder ์ ‘๊ทผ์ œ์–ด์ž privateโ€ฆ
19faa8b 
โ€ฆ์œผ๋กœ ์„ค์ •
@JungYoonShin
[โ™ป๏ธrefactor/#127]: ์Šคํฌ๋žฉ ๋ฐ ํ•„ํ„ฐ๋ง ๊ด€๋ จ API Contoller request ํƒ€์ž… ๋ณ€๊ฒฝ
0661eab 
- @AuthenticationPrincipal์„ ํ†ตํ•ด userId๋ฅผ ๊ฐ€์ ธ์˜ฌ ๋•Œ ๋ชจ๋“  API๊ฐ€ ์œ ์ € ์ธ์ฆ์ด ํ•„์ˆ˜์ด๋ฏ€๋กœ Long์—์„œ longํƒ€์ž…์œผ๋กœ ์ˆ˜์ •
- @PathVariable๋กœ internshipAnnouncementId๋ฅผ ๋ฐ›๋Š” ๊ฒฝ์šฐ default๊ฐ€ required=true์ด๋ฏ€๋กœ ํƒ€์ž…์„ Long์—์„œ long์œผ๋กœ ์ˆ˜์ •
@JungYoonShin
git commit -m "[โœจfeat/#127]: Spring AOP๋ฅผ ์ด์šฉํ•œ ์„ฑ๋Šฅํ…Œ์ŠคํŠธ ํ™˜๊ฒฝ ๊ตฌ์ถ•
2ff8734 
- Spring AOP๋ฅผ ์‚ฌ์šฉํ•˜์—ฌ ์Šคํฌ๋žฉ ์ƒ‰์ƒ ์ˆ˜์ •API - ์ƒ‰์ƒ(enum) ์กฐํšŒ์‹œ map๋ฅผ ํ™œ์šฉํ•œ ์บ์‹ฑ๊ณผ .values()๋ฅผ ํ†ตํ•œ ์ˆœ์ฐจ ํƒ์ƒ‰์˜ ์„ฑ๋Šฅ ์ฐจ์ด๋ฅผ ์•Œ์•„๋ณด๊ธฐ ์œ„ํ•œ ํ…Œ์ŠคํŠธ ํ™˜๊ฒฝ ๊ตฌ์ถ•
@JungYoonShin
[โ™ป๏ธrefactor/#129]: InternshipDetailResponseDto json ํ•„๋“œ ์ˆœ์„œ ๋ฐ ์ถ”๊ฐ€
21b9df4
@JungYoonShin
[โ™ป๏ธrefactor/#129]: ๊ณต๊ณ  ์ƒ์„ธ ์ •๋ณด ๋กœ์ง ์ˆ˜์ •
5f27148 
- InternshipDetailResponseDto ํ•„๋“œ ์ˆ˜์ •๋จ์— ๋”ฐ๋ผ DTO ์ƒ์„ฑ์‹œ์˜ ํŒŒ๋ผ๋ฏธํ„ฐ๋„ ์ˆ˜์ •
@JungYoonShin
[โ™ป๏ธrefactor/#129]: ํƒ์ƒ‰ > ์กฐํšŒ์ˆ˜/ํƒ์ƒ‰์ˆ˜ ๋งŽ์€ ๊ณต๊ณ  ์กฐํšŒ ๋กœ์ง ์ˆ˜์ •
822eeda 
- ๊ธฐํš์ธก ์š”๊ตฌ์‚ฌํ•ญ์— ๋”ฐ๋ผ 30 -> 60์ผ ๋ณด๋‹ค ์˜ค๋ž˜๋œ ๊ณต๊ณ ๋ฅผ ์ œ์™ธํ•˜๋„๋ก ์ˆ˜์ •
- ์˜ค๋ž˜๋œ ์ธํ„ด์‹ญ ๊ณต๊ณ ๋ฅผ ์ œ์™ธํ•˜๊ธฐ ์œ„ํ•ด ์‚ฌ์šฉ๋˜๋˜ '60์ผ' ๊ฐ’์„ ์ƒ์ˆ˜ํ™”(INTERNSHIP_CREATED_WITHIN_DAYS)ํ•˜์—ฌ ์ฝ”๋“œ ๊ฐ€๋…์„ฑ ๋ฐ ์œ ์ง€๋ณด์ˆ˜์„ฑ์„ ๊ฐœ์„ ํ•˜์˜€์Šต๋‹ˆ๋‹ค.
@jsoonworld
[โ™ป๏ธ refactor/#121]: AuthServiceImpl ๋ฆฌํŒฉํ† ๋ง: ๋ฉ”์„œ๋“œ ๋ช…๋ช… ์ผ๊ด€์„ฑ ๋ฐ ํŠธ๋žœ์žญ์…˜ ๊ด€๋ฆฌ ๊ฐœ์„ 
a7f2de5 
- ํ† ํฐ ์ƒ์„ฑ ๋ฉ”์„œ๋“œ๋ช…์„ `getToken()`์—์„œ `getFullToken()`์œผ๋กœ ๋ณ€๊ฒฝํ•˜์—ฌ ๋ช…ํ™•์„ฑ ํ–ฅ์ƒ
- `findUser()`๋ฅผ `findUserById()`์™€ `findUserByRefreshToken()`์œผ๋กœ ๋ณ€๊ฒฝํ•˜์—ฌ ๋ฉ”์„œ๋“œ ๋ช…๋ช… ์ผ๊ด€์„ฑ ํ™•๋ณด
- ๋ช‡๋ช‡ ๋ฉ”์„œ๋“œ์˜ ์ ‘๊ทผ ์ œ์–ด์ž๋ฅผ ์ˆ˜์ •ํ•˜์—ฌ ์บก์Šํ™” ๊ฐœ์„ 
- ๋ฐ์ดํ„ฐ๋ฒ ์ด์Šค ์ƒํƒœ๋ฅผ ์ˆ˜์ •ํ•˜๋Š” ๋ฉ”์„œ๋“œ์— `@Transactional` ์• ๋„ˆํ…Œ์ด์…˜ ์ถ”๊ฐ€๋กœ ํŠธ๋žœ์žญ์…˜ ๊ด€๋ฆฌ ๊ฐ•ํ™”
@JungYoonShin
[โ™ป๏ธrefactor/#129]: ๊ฒ€์ƒ‰ ํ™”๋ฉด ํŽ˜์ด์ง•์„ ํ†ตํ•œ ์ธํ„ด๊ณต๊ณ  ์กฐํšŒ์‹œ count ์ฟผ๋ฆฌ ์ˆ˜์ •
ff5400b 
- ์ธํ„ด๊ณต๊ณ ์˜ ์ด ๊ฐœ์ˆ˜๋ฅผ ๊ตฌํ•  ๋•Œ, ์ธํ„ด๊ณต๊ณ ๊ฐ€ ์—†์„ ๊ฒฝ์šฐ, ์ฆ‰ count๊ฐ€ null์ผ ๊ฒฝ์šฐ 0L์„ ๊ธฐ๋ณธ๊ฐ’์œผ๋กœ ์„ค์ •ํ•˜์—ฌ ํƒ€์ž… ์–ธ๋ฐฉ์‹์—์„œ ๋ฐœ์ƒํ•  ์ˆ˜ ์žˆ๋Š” NullPointerException ๋ฐœ์ƒ ์˜ˆ๋ฐฉ
@JungYoonShin
[โ™ป๏ธrefactor/#129]: ๊ฒ€์ƒ‰ responseDto ํ•„๋“œ ๋ณ€๊ฒฝ
1c06d46
@JungYoonShin
Merge pull request #128 from teamterning/refactor/#127
25fb5d0 
[โ™ป๏ธ refactor/#127]: ํ•„ํ„ฐ๋ง ๊ด€๋ จ API ์ˆ˜์ • ๋ฐ Spring AOP๋ฅผ ์‚ฌ์šฉํ•œ ์„ฑ๋Šฅํ…Œ์ŠคํŠธ ํ™˜๊ฒฝ ๊ตฌ์ถ•
@jsoonworld
[โ™ป๏ธ refactor/#121] getFullToken ๋ฐ deleteUser ๋ฉ”์„œ๋“œ์˜ ์ ‘๊ทผ ์ œ์–ด์ž๋ฅผ protected์—์„œโ€ฆ
0f59718 
โ€ฆ private์œผ๋กœ ๋ณ€๊ฒฝ

- ๋‚ด๋ถ€์—์„œ๋งŒ ์‚ฌ์šฉ๋˜๋Š” getFullToken ๋ฉ”์„œ๋“œ๋ฅผ private์œผ๋กœ ์ˆ˜์ •.
- ์บก์Šํ™” ๋ฐ ์ ‘๊ทผ ์ œํ•œ์„ ์œ„ํ•ด deleteUser ๋ฉ”์„œ๋“œ๋ฅผ private์œผ๋กœ ๋ณ€๊ฒฝ.
- ํ•ด๋‹น ๋ฉ”์„œ๋“œ์—์„œ ๋ถˆํ•„์š”ํ•œ @transactional ์–ด๋…ธํ…Œ์ด์…˜ ์ œ๊ฑฐ.
@jsoonworld
Merge pull request #130 from teamterning/refactor/#121
3c20eeb 
[โ™ป๏ธ refactor/#121]: AuthServiceImpl ๋ฆฌํŒฉํ† ๋ง: ๋ฉ”์„œ๋“œ ๋ช…๋ช… ์ผ๊ด€์„ฑ ๋ฐ ํŠธ๋žœ์žญ์…˜ ๊ด€๋ฆฌ ๊ฐœ์„ 
@junggyo1020
[โ™ป๏ธ refactor] ํ™ˆํ™”๋ฉด > ๊ณง ๋งˆ๊ฐ๋˜๋Š” ๊ด€์‹ฌ ๊ณต๊ณ  ์ „๋‹ฌ ๋ฐ์ดํ„ฐ ์ˆ˜์ •
b7c6322
@JungYoonShin
[โ™ป๏ธrefactor/#129]: Color enum ์ƒ‰์ƒ ์ฐพ์„ ๋•Œ ์˜ˆ์™ธ์ฒ˜๋ฆฌ ์ถ”๊ฐ€
4e92e6d 
- ์Šคํฌ๋žฉ ์ˆ˜์ • ๋ฐ ์ถ”๊ฐ€ ์‹œ ์ƒ‰์ƒ ์ •๋ณด๋ฅผ ์ฐพ์„ ๋•Œ, ์ž˜๋ชป๋œ ๊ฐ’์ด ๋“ค์–ด์™”์„ ๊ฒฝ์šฐ์— ๋Œ€ํ•œ ์˜ˆ์™ธ์ฒ˜๋ฆฌ ์ถ”๊ฐ€
@JungYoonShin
Merge pull request #132 from teamterning/refactor/#129
aef33a5 
[โ™ป๏ธ refactor/#129]: ๊ณต๊ณ  ์ƒ์„ธ ์ •๋ณด ๋ฐ ๊ฒ€์ƒ‰ ๊ฒฐ๊ณผ ํ™”๋ฉด response body ์ˆ˜์ •
@junggyo1020
Merge pull request #133 from teamterning/refactor/131
c78c121 
[โ™ป๏ธ refactor/#131] ํ™ˆํ™”๋ฉด > ๊ณง ๋งˆ๊ฐ๋˜๋Š” ๊ด€์‹ฌ ๊ณต๊ณ  ์ „๋‹ฌ ๋ฐ์ดํ„ฐ ์ˆ˜์ •
@junggyo1020 junggyo1020 added ๐Ÿ”€ย merge ๋‹ค๋ฅธ ๋ธŒ๋žœ์น˜์™€ ๋ณ‘ํ•ฉ ๐Ÿถ์ •๊ต๐Ÿถ labels Sep 11, 2024
@junggyo1020 junggyo1020 self-assigned this Sep 11, 2024
@junggyo1020 junggyo1020 merged commit 379ab91 into staging Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JungYoonShin JungYoonShin Awaiting requested review from JungYoonShin

@jsoonworld jsoonworld Awaiting requested review from jsoonworld

Assignees

@junggyo1020 junggyo1020

Labels
๐Ÿถ์ •๊ต๐Ÿถ ๐Ÿ”€ย merge ๋‹ค๋ฅธ ๋ธŒ๋žœ์น˜์™€ ๋ณ‘ํ•ฉ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@junggyo1020 @JungYoonShin @jsoonworld