-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[✨ feat/#123] 마이페이지 > 프로필 정보 이미지 전달방식 변경 & 마이페이지 > 프로필 수정 기능 추가 #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JungYoonShin
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다~! 주석을 깔끔하게 잘 써주셔서 코드 이해하기가 수월했습니다!
src/main/java/org/terning/terningserver/domain/enums/ProfileImage.java
Outdated
Show resolved
Hide resolved
src/main/java/org/terning/terningserver/service/UserServiceImpl.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Work Description
int
타입에서String
타입으로 전달 받도록 변경했습니다.(6개의 String Enum 타입 중 하나:
basic
,lucky
,smart
,glass
,calendar
,passion
)basic
으로 설정되도록 구현하였습니다.(6개의 String Enum 타입 중 하나:
basic
,lucky
,smart
,glass
,calendar
,passion
)⚙️ ISSUE
📷 Screenshot
1. 회원가입 API : profileImage 전달방식 변경
int
>>String
2. 프로필 정보 불러오기 API : profileImage를 추가로 전달하도록 응답 수정
3. 프로필 수정하기 API
💬 To Reviewers
기존의 코드와 변경된 부분이 많고, 회원가입 로직에 코드를 추가했기 때문에 꼼꼼하게 확인해주시면 감사하겠습니다:)
잘못된 부분이 있거나 개선할 부분이 있다면 편하게 말씀해주세요!
🔗 Reference
문제를 해결하면서 도움이 되었거나, 참고했던 사이트(코드링크)