[♻️ refactor/#114]: signIn 메서드 리팩토링 및 코드 개선 #119
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Work Description
⚙️ ISSUE
📷 Screenshot
Swagger 200
💬 To Reviewers
이전 PR에서 의견이 나왔었는데요. private 메서드에 update 로직이 담겨 있으니 transcation을 붙여주는 게 낫다는 의견이 있었거든요, 제 생각에는 private 메서드를 사용하는 메서드에서 transaction을 사용하니, 중복을 제거하고자 붙이지 않아도 문제 없다는 생각이었습니다. 그 메서드를 다르 곳에서 사용하는 것이 아니기 때문에요. 그러나 메서드를 불러서 사용할 수 있다는 문제도 존재합니다. 어떻게 생각하시나요!?