Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX/#273] 다이얼로그 QA 반영 #276

Merged
merged 2 commits into from
Oct 6, 2024
Merged

[FIX/#273] 다이얼로그 QA 반영 #276

merged 2 commits into from
Oct 6, 2024

Conversation

boiledEgg-s
Copy link
Member

⛳️ Work Description

  • 스크랩 수정 시 토스트 메시지 추가

📸 Screenshot

241002_.mp4

*📢 To Reviewers

  • 최종 QA 반영했습니다~
  • 문득 드는 생각인데 혹시 다른 분들은 각각의 화면에서 스크랩 수정 시 토스트 메시지가 나오도록 하셨나요??

@boiledEgg-s boiledEgg-s added FIX 🔨 버그 및 오류 해결 석준💜 석준 labels Oct 2, 2024
@boiledEgg-s boiledEgg-s added this to the 2차 스프린트 작업 milestone Oct 2, 2024
@boiledEgg-s boiledEgg-s self-assigned this Oct 2, 2024
leeeyubin
leeeyubin approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@leeeyubin leeeyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

룩베리굿투미~~

Hyobeen-Park
Hyobeen-Park approved these changes Oct 5, 2024
View reviewed changes
Copy link
Member

@Hyobeen-Park Hyobeen-Park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

룻베리굿투미~!

그리고 저는 스크랩 할 때는 토스트 뜨는데 수정할 때는 안 뜨네욤😂

arinming
arinming approved these changes Oct 5, 2024
View reviewed changes
Copy link
Contributor

@arinming arinming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
저는 스크랩 수정 부분이 없습니당

@boiledEgg-s boiledEgg-s merged commit f454c3f into develop Oct 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arinming arinming arinming approved these changes

@Hyobeen-Park Hyobeen-Park Hyobeen-Park approved these changes

@leeeyubin leeeyubin leeeyubin approved these changes

Assignees

@boiledEgg-s boiledEgg-s

Labels
FIX 🔨 버그 및 오류 해결 석준💜 석준
Projects
None yet
Milestone
2차 스프린트 작업
Development

Successfully merging this pull request may close these issues.

[FIX] 다이얼로그 최종 QA
4 participants
@boiledEgg-s @arinming @Hyobeen-Park @leeeyubin