[FIX/#236] 홈 뷰 / 1차 QA 반영 #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeeyubin
approved these changes
Sep 12, 2024
Comment on lines
87
to
90
| Text( | ||
| text = dateDeadline, | ||
| style = TerningTheme.typography.detail0, | ||
| color = TerningMain, | ||
| color = if (dateDeadline == "지원마감") Grey300 else TerningMain, |
Comment on lines
88
to
91
| LaunchedEffect(key1 = true) { | ||
| viewModel.getProfile() | ||
| viewModel.getFilteringInfo() | ||
| } |
boiledEgg-s
approved these changes
Sep 12, 2024
| @@ -86,7 +87,7 @@ fun InternItem( | |||
| Text( | |||
| text = dateDeadline, | |||
| style = TerningTheme.typography.detail0, | |||
| color = TerningMain, | |||
| color = if (dateDeadline == stringResource(id = R.string.intern_apply_closed)) Grey300 else TerningMain, | |||
arinming
approved these changes
Sep 13, 2024
Comment on lines
+182
to
+186
| if (homeState.homeRecommendDialogVisibility) { | ||
| with(homeState.homeInternModel) { | ||
| if (this != null) { | ||
| if (isScrapped) { | ||
| ScrapCancelDialog( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
Screen_Recording_20240912_233829_terning.mp4
📢 To Reviewers