Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD/#201] 공통 컴포넌트 문서화 #237

Merged
merged 7 commits into from
Sep 11, 2024
Merged

[ADD/#201] 공통 컴포넌트 문서화 #237

merged 7 commits into from
Sep 11, 2024

Conversation

boiledEgg-s
Copy link
Member

⛳️ Work Description

  • 담당 컴포넌트에 주석 추가

📸 Screenshot

UI 수정은 전혀 없습니다!

📢 To Reviewers

  • 진작 했었어야 했는데, 다른 일에 치여 이제 하게 됐네요,, 약간 보여주기식 문서화가 된 느낌쓰...ㅎㅎ
  • UI를 바꾸거나 한 건 아니니까 천천히 리뷰해주셔도 됩니당~
  • 그리고 feature/intern 쪽에 남아있던 dialog의 잔해도 삭제했으니까 확인해주세여!!

@boiledEgg-s boiledEgg-s added ADD ➕ 부수적인 코드 추가 및 라이브러리 추가, 새로운 파일 생성 석준💜 석준 labels Sep 10, 2024
@boiledEgg-s boiledEgg-s added this to the 2차 스프린트 작업 milestone Sep 10, 2024
@boiledEgg-s boiledEgg-s self-assigned this Sep 10, 2024
leeeyubin
leeeyubin approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@leeeyubin leeeyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엘지티엠~!!

Hyobeen-Park
Hyobeen-Park approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@Hyobeen-Park Hyobeen-Park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엘지티엠~!!

arinming
arinming approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@arinming arinming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엘지티엠~~~~~~!!!!

@boiledEgg-s boiledEgg-s merged commit 2c6d288 into develop Sep 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arinming arinming arinming approved these changes

@Hyobeen-Park Hyobeen-Park Hyobeen-Park approved these changes

@leeeyubin leeeyubin leeeyubin approved these changes

Assignees

@boiledEgg-s boiledEgg-s

Labels
ADD ➕ 부수적인 코드 추가 및 라이브러리 추가, 새로운 파일 생성 석준💜 석준
Projects
None yet
Milestone
2차 스프린트 작업
Development

Successfully merging this pull request may close these issues.

[ADD] 담당 컴포넌트 문서화
4 participants
@boiledEgg-s @arinming @Hyobeen-Park @leeeyubin