[REFACTOR/#212] 다이얼로그 / 리팩토링 #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeeyubin
approved these changes
Sep 1, 2024
Comment on lines
+101
to
+104
| with(viewModel){ | ||
| updateScrapId(scrapId) | ||
| updateScrapCancelDialogVisibility(true) | ||
| } |
arinming
approved these changes
Sep 4, 2024
Comment on lines
+8
to
+11
| @Composable | ||
| fun TextStyle.getFixHeightByMaxLine(maxLine: Int): Dp = with(LocalDensity.current) { | ||
| lineHeight.toDp() * maxLine | ||
| } |
Comment on lines
+42
to
+43
| val interactionSource = remember { MutableInteractionSource() } | ||
| val isPressed by interactionSource.collectIsPressedAsState() |
Comment on lines
91
to
94
| Image( | ||
| painter = painterResource(id = R.drawable.ic_color_check), | ||
| contentDescription = "" | ||
| ) |
There was a problem hiding this comment.
TerningImage 사용하시는 거 어떨까요!?
TerningImage( painter = R.drawable.ic_color_check, )
There was a problem hiding this comment.
지난 회의때 contentDescription을 통일하지 말고 직접 쓰자는 의견이 나왔었어요! 하드코딩을 하더라도 채워넣기로 정했습니다!! 8월 4주차 안드회의 보러가기
이 부분은 TerningImage는 안쓰더라도 고치긴 해야겠네요!!
leeeyubin
approved these changes
Sep 4, 2024
Comment on lines
3
to
5
| sealed class ScrapDialogSideEffect{ | ||
| data class ShowToast(val message: Int): ScrapDialogSideEffect() | ||
| data object DismissDialog : ScrapDialogSideEffect() |
There was a problem hiding this comment.
@StringRes 어노테이션 넣어주면 더 좋을 것 같아요!
Comment on lines
+40
to
+43
| }, | ||
| verticalArrangementSpace = 6.dp, | ||
| horizontalArrangementSpace = 0.dp, | ||
| modifier = modifier.wrapContentSize() |
There was a problem hiding this comment.
넵! RadioButtonGroups 컴포넌트를 만들 때 기본값을 안받도록 구현해서 직접 넣어줘야됩니다!!
Hyobeen-Park
approved these changes
Sep 6, 2024
| } | ||
| } | ||
|
|
||
| val swipeModifier = Modifier.pointerInput(Unit) { |
There was a problem hiding this comment.
우왕 swipe 기능까지 구현하다니!! 짱이다👍🏻
| ) | ||
| val internalBoxModifier = Modifier | ||
| .padding(4.dp) | ||
| .then( |
# Conflicts: # feature/src/main/java/com/terning/feature/intern/component/InternInfoRow.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
리팩토링
2차 스프린트
📸 Screenshot
스크랩 수정 (꽤 많이 수정됨)
default.mp4
스크랩 취소 (마진 정도만 바뀜)
default.mp4
📢 To Reviewers
잘 살펴보고 혹시 본인이 구현한 코드에 적용이 힘들 것 같다 싶으면 코멘트에 그렇게 생각한 부분과 이유를 적어주세요!! 전부 다 반영해서 수정하도록 할게요!
-------------- 9월 3일 변경사항 --------------