Skip to content

Commit

Permalink
Merge remote-tracking branch 'refs/remotes/origin/develop' into fix/#279
Browse files Browse the repository at this point in the history
-home-qa
  • Loading branch information
Hyobeen-Park committed Oct 6, 2024
2 parents 9981443 + abb9dde commit 0730c1b
Show file tree
Hide file tree
Showing 27 changed files with 78 additions and 44 deletions.
30 changes: 28 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@

<br>

## DOWNLOAD
<a href="https://play.google.com/store/apps/details?id=com.terning.point"><img src="https://play.google.com/intl/en_us/badges/static/images/badges/en_badge_web_generic.png" height="100"></a>


## CONTRIBUTORS
| πŸ‘‘μ΄μœ λΉˆ<br/>([@leeeyubin](https://github.com/leeeyubin)) | 이석쀀<br/>([@boiledEgg-s](https://github.com/boiledEgg-s)) | κΉ€μ•„λ¦°<br/>([@arinming](https://github.com/arinming)) | λ°•νš¨λΉˆ<br/>([@Hyobeen-Park](https://github.com/Hyobeen-Park)) |
|:---------------------------------------------------------------------------------------------------------------------------:|:---------------------------------------------------------------------------------------------------------------------------:|:---------------------------------------------------------------------------------------------------------------------------:|:---------------------------------------------------------------------------------------------------------------------------:|
Expand All @@ -28,7 +32,12 @@

<br>

## DEPENDENCY GRAPH
<img width="300px" src="https://github.com/user-attachments/assets/9f730e35-2ecf-4d1f-a170-e08a4836fe8a"/>


## MODULE & PACKAGE CONVENTION

```
πŸ—ƒοΈapp
Expand All @@ -41,6 +50,7 @@
┣ πŸ“‚extension
┣ πŸ“‚navigation
┣ πŸ“‚state
┣ πŸ“‚type
β”— πŸ“‚util
πŸ—ƒοΈdata
Expand All @@ -50,19 +60,19 @@
┃ ┣ πŸ“‚response
┃ ┣ πŸ“‚request
┣ πŸ“‚local
┣ πŸ“‚mapper
┣ πŸ“‚repositoryImpl
β”— πŸ“‚service
πŸ—ƒοΈdomain
┣ πŸ“‚entity
┃ ┣ πŸ“‚response
┃ ┣ πŸ“‚request
β”— πŸ“‚repository
πŸ—ƒοΈfeature
β”— πŸ“‚κΈ°λŠ₯ 별 νŒ¨ν‚€μ§•
```

<br>

## TECH STACK
Expand All @@ -78,6 +88,22 @@
| Other Tools | Discode, Notion, Figma |\
</br>

## SCREENSHOTS
| λ·° | 1 | 2 | 3 |
|:-------------:|:---------------------------------------------------------------------------------------------------------------------------:|:---------------------------------------------------------------------------------------------------------------------------:|:---------------------------------------------------------------------------------------------------------------------------:|
| μ˜¨λ³΄λ”© <br> 필터링 μ„€μ • | <img width="200px" src="https://github.com/user-attachments/assets/e3b39df0-78f3-4c7b-8049-f5133f18d419"/> | <img width="200px" src="https://github.com/user-attachments/assets/f3cd3efb-b0bc-4bf3-b3ee-0a8be316883a"/> | <img width="200px" src="https://github.com/user-attachments/assets/11d5283c-0537-484a-b822-bcb291e79203"/> | | |
| ν™ˆ <br> 필터링 μž¬μ„€μ • | <img width="200px" src="https://github.com/user-attachments/assets/4f558239-fde5-41d7-b7d8-6988b3091fe6"/> | <img width="200px" src="https://github.com/user-attachments/assets/5c7d77d3-3cdc-4f30-8b1d-4e1878266f04"/> | <img width="200px" src="https://github.com/user-attachments/assets/d3202b3b-d8fe-42cf-b7aa-3e54be928736"/> |
| μΊ˜λ¦°λ” μ›”κ°„ <br> μΊ˜λ¦°λ” μ£Όκ°„ | <img width="200px" src="https://github.com/user-attachments/assets/0af96542-a560-41f6-87e1-a063dbc49e7c"/> | <img width="200px" src="https://github.com/user-attachments/assets/5d50db13-40af-4f40-b395-235d1560a023"/> | <img width="200px" src="https://github.com/user-attachments/assets/cfdf0ef3-e299-43ba-8208-97d46b320acf"/> |
| 탐색 <br> 곡고 상세 νŽ˜μ΄μ§€ | <img width="200px" src="https://github.com/user-attachments/assets/0505ed7f-407a-46dd-a06d-22974da5097a"/> | <img width="200px" src="https://github.com/user-attachments/assets/c7c1ff76-2160-4a96-873e-edd069ddf824"/> | <img width="200px" src="https://github.com/user-attachments/assets/c78b5d07-fbbc-408d-b088-3b94ebc3350e"/> |
| λ§ˆμ΄νŽ˜μ΄μ§€ <br> ν”„λ‘œν•„ μˆ˜μ • | <img width="200px" src="https://github.com/user-attachments/assets/53b9fb41-9190-4f21-98fb-416d52703e55"/> | <img width="200px" src="https://github.com/user-attachments/assets/678c19cd-3aa5-4056-a807-82fbfc307dac"/> | <img width="200px" src="https://github.com/user-attachments/assets/1e7311d4-34b6-4a12-907a-5afbf68ef898"/> |

<br>


## DESIGN SYSTEM
πŸ”— [TERNING DESIGN SYSTEM](https://teamterning.github.io/Terning-Android/index.html)


## KANBAN BOARD
πŸ”— [TERNING PROJECT](https://github.com/orgs/teamterning/projects/1)

Expand Down
2 changes: 1 addition & 1 deletion app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
android:allowBackup="true"
android:dataExtractionRules="@xml/data_extraction_rules"
android:fullBackupContent="@xml/backup_rules"
android:icon="@mipmap/ic_terning_launcher_foreground"
android:icon="@mipmap/ic_terning_launcher"
android:label="@string/app_name"
android:roundIcon="@mipmap/ic_terning_launcher_round"
android:supportsRtl="true"
Expand Down
6 changes: 3 additions & 3 deletions core/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,9 @@

<!--NameTextField-->
<string name="sign_up_helper">12자리 이내, 문자/숫자 κ°€λŠ₯, 특수문자/기호 μž…λ ₯λΆˆκ°€</string>
<string name="sign_up_helper_error">이름에 νŠΉμˆ˜λ¬ΈμžλŠ” μž…λ ₯ν•  수 μ—†μ–΄μš”</string>
<string name="sign_up_helper_available">μ‚¬μš© κ°€λŠ₯ν•œ μ΄λ¦„μ΄μ—μš”</string>
<string name="sign_up_helper_out">이름은 12자리 μ΄λ‚΄λ‘œ μ„€μ •ν•΄ μ£Όμ„Έμš”</string>
<string name="sign_up_helper_error">λ‹‰λ„€μž„μ— νŠΉμˆ˜λ¬ΈμžλŠ” μž…λ ₯ν•  수 μ—†μ–΄μš”</string>
<string name="sign_up_helper_available">μ‚¬μš© κ°€λŠ₯ν•œ λ‹‰λ„€μž„μ΄μ—μš”</string>
<string name="sign_up_helper_out">λ‹‰λ„€μž„μ€ 12자리 μ΄λ‚΄λ‘œ μ„€μ •ν•΄ μ£Όμ„Έμš”</string>

<!--ChangeFilter-->
<string name="change_filter_top_bar_title">필터링 μž¬μ„€μ •</string>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,16 +32,19 @@ fun CalendarDay(
onDateSelected: (LocalDate) -> Unit = {}
) {
val backgroundColor =
if (isSelected) TerningMain else if (isToday) Grey200 else Color.Transparent
if (isSelected)
TerningMain
else if (isToday) Grey150
else Color.Transparent

val textColor =
if (dayData.isOutDate) {
Grey150
} else {
if (isSelected)
White
else
Black
}
if (dayData.isOutDate)
Grey200
else if (isSelected)
White
else
Black


Box(
modifier = modifier,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ fun ScrapDialog(
is ScrapDialogSideEffect.PatchedScrap -> {
onClickChangeColor()
onDismissRequest(false)
context.toast(R.string.dialog_content_calendar_color_change_complete)
}

is ScrapDialogSideEffect.NavigateToDetail -> onClickNavigateButton(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ fun InternCompanyInfo(
contentScale = ContentScale.Fit,
modifier = Modifier
.fillMaxWidth()
.clip(CircleShape),
)
}
Column(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ import androidx.compose.ui.res.stringResource
import androidx.compose.ui.unit.dp
import com.terning.core.designsystem.component.image.TerningImage
import com.terning.core.designsystem.theme.Black
import com.terning.core.designsystem.theme.Grey100
import com.terning.core.designsystem.theme.Grey300
import com.terning.core.designsystem.theme.Grey375
import com.terning.core.designsystem.theme.TerningMain
import com.terning.core.designsystem.theme.TerningSub3
Expand All @@ -38,7 +40,11 @@ fun InternTitle(
Row(
modifier = Modifier
.background(
color = TerningSub3,
color = if (dDay != "μ§€μ›λ§ˆκ°") {
TerningSub3
} else {
Grey100
},
shape = RoundedCornerShape(size = 5.dp)
)
.width(70.dp)
Expand All @@ -49,7 +55,11 @@ fun InternTitle(
Text(
text = dDay,
style = TerningTheme.typography.title3,
color = TerningMain,
color = if (dDay != "μ§€μ›λ§ˆκ°") {
TerningMain
} else {
Grey300
}
)
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.terning.feature.mypage.mypage.component

import androidx.compose.foundation.Image
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.fillMaxWidth
Expand All @@ -9,6 +10,7 @@ import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.res.painterResource
import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp
import com.terning.core.designsystem.component.image.TerningImage
Expand Down Expand Up @@ -38,8 +40,9 @@ fun MyPageItem(
Row(
verticalAlignment = Alignment.CenterVertically
) {
TerningImage(
painter = icon,
Image(
painter = painterResource(id = icon),
contentDescription = "my page image",
modifier = modifier.size(28.dp)
)
Text(
Expand All @@ -51,7 +54,7 @@ fun MyPageItem(
if (version.isNotEmpty())
Text(
text = version,
modifier = modifier.padding(end = 16.dp),
modifier = modifier.padding(end = 7.dp),
style = TerningTheme.typography.button4,
color = Grey350
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,18 +27,16 @@ fun ImageSlider(
images: List<Int>,
onAdvertisementClick: () -> Unit,
) {
val infiniteImages = remember { images + images + images }
val pagerState = rememberPagerState(
initialPage = images.size,
initialPageOffsetFraction = 0f,
pageCount = { infiniteImages.size }
initialPage = 0,
pageCount = { Int.MAX_VALUE }
)
val autoScroll = remember { mutableStateOf(true) }

LaunchedEffect(autoScroll.value) {
if (autoScroll.value) {
while (true) {
delay(2000)
delay(3000)
if (!pagerState.isScrollInProgress) {
val nextPage = pagerState.currentPage + 1
pagerState.animateScrollToPage(nextPage)
Expand All @@ -47,14 +45,6 @@ fun ImageSlider(
}
}

LaunchedEffect(pagerState.currentPage) {
if (pagerState.currentPage < images.size) {
pagerState.scrollToPage(pagerState.currentPage + images.size)
} else if (pagerState.currentPage >= 2 * images.size) {
pagerState.scrollToPage(pagerState.currentPage - images.size)
}
}

Column(
modifier
.fillMaxWidth()
Expand All @@ -68,10 +58,11 @@ fun ImageSlider(
HorizontalPager(
state = pagerState,
modifier = modifier,
beyondViewportPageCount = infiniteImages.size
beyondViewportPageCount = 1
) { currentPage ->
val pageIndex = currentPage % images.size
Image(
painter = painterResource(id = infiniteImages[currentPage % images.size]),
painter = painterResource(id = images[pageIndex]),
contentDescription = null,
modifier = modifier
.fillMaxWidth()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ fun SearchProcessScreen(
}
}

if (state.existSearchResults) {
if (internSearchResultData.isNotEmpty()) {
LazyColumn(
contentPadding = PaddingValues(
top = 12.dp,
Expand Down Expand Up @@ -319,6 +319,7 @@ fun SearchProcessScreen(
color = Grey400,
)
}

}
}
}
Expand Down
Binary file modified feature/src/main/res/mipmap-hdpi/ic_terning_launcher.webp
Binary file not shown.
Binary file not shown.
Binary file modified feature/src/main/res/mipmap-hdpi/ic_terning_launcher_round.webp
Binary file not shown.
Binary file modified feature/src/main/res/mipmap-mdpi/ic_terning_launcher.webp
Binary file not shown.
Binary file not shown.
Binary file modified feature/src/main/res/mipmap-mdpi/ic_terning_launcher_round.webp
Binary file not shown.
Binary file modified feature/src/main/res/mipmap-xhdpi/ic_terning_launcher.webp
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified feature/src/main/res/mipmap-xxhdpi/ic_terning_launcher.webp
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified feature/src/main/res/mipmap-xxxhdpi/ic_terning_launcher.webp
Binary file not shown.
Binary file not shown.
Binary file not shown.
8 changes: 4 additions & 4 deletions feature/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@
<string name="sign_in_kakao_cancel">λ‘œκ·ΈμΈμ„ μ·¨μ†Œν•˜μ˜€μŠ΅λ‹ˆλ‹€</string>

<!--SignUp-->
<string name="sign_up_title">λ°˜κ°€μ›Œμš”!\n이름을 μ•Œλ €μ£Όμ„Έμš”</string>
<string name="sign_up_title">λ°˜κ°€μ›Œμš”!\nλ‹‰λ„€μž„μ„ μ•Œλ €μ£Όμ„Έμš”</string>
<string name="sign_up_profile_image">ν”„λ‘œν•„ 이미지</string>
<string name="sign_up_profile_button">ν”„λ‘œν•„ λ²„νŠΌ</string>
<string name="sign_up_name">이름</string>
<string name="sign_up_hint">이름을 μž…λ ₯ν•΄ μ£Όμ„Έμš”</string>
<string name="sign_up_name">λ‹‰λ„€μž„</string>
<string name="sign_up_hint">λ‹‰λ„€μž„μ„ μž…λ ₯ν•΄ μ£Όμ„Έμš”</string>
<string name="sign_up_next_button">λ‹€μŒμœΌλ‘œ</string>

<!--Search-->
Expand Down Expand Up @@ -60,7 +60,7 @@
<string name="dialog_content_scrap_sub_title">곡고λ₯Ό μΊ˜λ¦°λ”μ— μŠ€ν¬λž©ν•˜μ‹œκ² μ–΄μš”?</string>
<string name="dialog_content_color_button">슀크랩 색상</string>
<string name="dialog_content_calendar_color_change">색상 λ³€κ²½ν•˜κΈ°</string>
<string name="dialog_content_calendar_color_change_complete">색상 λ³€κ²½μ™„λ£Œ</string>
<string name="dialog_content_calendar_color_change_complete">슀크랩 색상이 λ³€κ²½λ˜μ—ˆμ–΄μš”!</string>
<string name="dialog_scrap_button">λ‚΄ μΊ˜λ¦°λ”μ— μŠ€ν¬λž©ν•˜κΈ°</string>
<string name="dialog_content_scrap_cancel_main_title">관심 곡고가 μΊ˜λ¦°λ”μ—μ„œ μ‚¬λΌμ Έμš”!</string>
<string name="dialog_content_scrap_cancel_sub_title">μŠ€ν¬λž©μ„ μ·¨μ†Œν•˜μ‹œκ² μ–΄μš”?</string>
Expand Down
6 changes: 3 additions & 3 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@
compileSdk = "34"
minSdk = "28"
targetSdk = "34"
versionName = "1.1.0"
versionCode = "10100"
versionName = "1.1.2"
versionCode = "10102"
kotlinCompilerExtensionVersion = "1.5.0"
jvmTarget = "1.8"

## Android gradle plugin
androidGradlePlugin = "8.6.0"
androidGradlePlugin = "8.5.0"
androidDesugarJdkLibs = "2.0.4"

## AndroidX
Expand Down

0 comments on commit 0730c1b

Please sign in to comment.