Add editor-config-bundle and make fragment configuration more simple #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-bundle into feature/use-editor-config # Conflicts: # src/DocumentAreabrick/Base/AbstractConfigurableAreabrick.php
jdreesen
reviewed
Jan 22, 2023
Comment on lines
-11
to
-13
| <div class="brick-{{ brickName }} {{ isFragment }} {{ fragmentStyle }}" {{ fragmentOrder }}> | ||
| {% block brick %}{% endblock %} | ||
| </div> |
There was a problem hiding this comment.
I don't think this should be removed.
lukadschaak
reviewed
Jan 23, 2023
jdreesen
reviewed
Jan 31, 2023
| @@ -19,7 +19,8 @@ | |||
| "symfony/dependency-injection": "^5.3", | |||
| "symfony/event-dispatcher": "^5.2", | |||
| "symfony/finder": "^5.2", | |||
| "symfony/http-kernel": "^5.3" | |||
| "symfony/http-kernel": "^5.3", | |||
| "teamneusta/pimcore-areabrick-config-bundle": "dev-main" | |||
There was a problem hiding this comment.
We should wait for a v1.0 to be released before this is merged.
jdreesen
reviewed
Jan 31, 2023
Comment on lines
+17
to
+20
| protected function createDialogBoxBuilder(Editable $area, ?Info $info): DialogBoxBuilder | ||
| { | ||
| return new DialogBoxBuilder(); | ||
| } |
There was a problem hiding this comment.
We don't need to overwrite this, it's the same as the default in the trait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.