[fix] 위니피드, 마이피드 / 스크롤 위치 문제, 좋아요 ui 반영문제 해결 #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 TroubleShooting
|
leeeha
approved these changes
Aug 27, 2023
| is LoadState.Error -> { | ||
| Timber.tag("failure").e(MSG_WINEYFEED_ERROR) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
오홍 페이징에서 LoadState 라는 걸 제공하는군요!! 페이징에 대해 저도 더 알아보고 싶네용 👀
| @@ -309,6 +337,8 @@ class WineyFeedFragment : | |||
| } | |||
|
|
|||
| private fun navigateToDetail(wineyFeed: WineyFeed) { | |||
| selectedItemIndex = wineyFeedAdapter.snapshot().indexOf(wineyFeed) | |||
| selectedScrollPosition = binding.rvWineyfeedPost.layoutManager?.onSaveInstanceState() | |||
There was a problem hiding this comment.
오오 스크롤 위치 저장하고 다시 불러오는 식으로 될 거 같았는데 결국 해냈네!! 갓-혜선 최고 💚
| notifyItemChanged(index) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
페이징 쓰더라도 일부 아이템만 변경할 수 있네요?! ㅎㅎ
저번에 snapshot().items 로 리스트 얻어올 수 있다고 리뷰 달았던 거 같은데, 전체를 리프레시 하지 않고 일부 아이템만 갱신하는 방법 찾아서 넘 다행이에용 💖
There was a problem hiding this comment.
items까지만 가능하고 안의 index까지는 접근할수 있을지 몰랐어요 ㅎㅎㅎ 페이징 욕했던날들 반성 중 ... 😻
| if (animator is SimpleItemAnimator) { | ||
| animator.supportsChangeAnimations = false | ||
| } | ||
| } |
| @@ -29,7 +29,7 @@ class MyFeedViewModel @Inject constructor( | |||
| val getMyFeedListState: StateFlow<UiState<PagingData<WineyFeed>>> = | |||
| _getMyFeedListState.asStateFlow() | |||
|
|
|||
| private val _postMyFeedLikeState = MutableStateFlow<UiState<Like>>(UiState.Loading) | |||
| private val _postMyFeedLikeState = MutableStateFlow<UiState<Like>>(UiState.Empty) | |||
There was a problem hiding this comment.
저도 위니 업로드에서 UiState 초기값을 로딩으로 잘못 줘서, 업로드가 되지 않는 이슈가 있었는데
여기도 비슷한 원인이었네요! 트러블 슈팅 굿굿 👍👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Work Description
📣 To Reviewers
일요일 저녁전까지 부탁드립니다 ~
자세한 원인이 궁금하면 아래 트러블슈팅 기록을 참고해주세용