[mod] 상세 피드 댓글 / 1차 릴리즈 QA 피드백 반영 #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 화면에 터치 이벤트가 발생하면 에디트텍스트 포커스 해제 - 에디트텍스트 포커스가 활성화 되면 리스트의 가장 마지막 아이템으로 스크롤 위치 변경 - 에디트 텍스트 배경 수정
…o feature/mod-detail-comment
sxunea
approved these changes
Aug 26, 2023
Comment on lines
79
to
86
| private fun initEditTextFocusChangeListener() { | ||
| binding.etComment.setOnFocusChangeListener { view, hasFocus -> | ||
| if (hasFocus) { | ||
| val commentListSize = commentAdapter.currentList.size | ||
| binding.rvDetail.smoothScrollToPosition(commentListSize + 1) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
이 부분 어떻게 할지 궁금했었는데 setOnFocusChangeListener 방법 너무 좋네요
| @@ -70,6 +70,7 @@ class DetailActivity : BindingActivity<ActivityDetailBinding>(R.layout.activity_ | |||
|
|
|||
| initEditTextFocusChangeListener() | |||
| updateStatusBarColor() | |||
| binding.tvCommentCreate.bringToFront() | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Work Description
📣 To Reviewers