[feat] 상세 피드 / 피드와 댓글 같이 스크롤 되도록 구현 #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m/team-winey/Winey-AOS into feature/feat-create-feed-comment � Conflicts: � app/src/main/java/com/android/go/sopt/winey/presentation/main/feed/WineyFeedFragment.kt � app/src/main/java/com/android/go/sopt/winey/presentation/main/mypage/myfeed/MyFeedFragment.kt � app/src/main/res/values/strings.xml
…o feature/feat-create-feed-comment
…o feature/feat-create-feed-comment � Conflicts: � app/src/main/java/com/android/go/sopt/winey/util/binding/BindingAdapter.kt
…o feature/feat-create-feed-comment
…m/team-winey/Winey-AOS into feature/feat-create-feed-comment � Conflicts: � app/src/main/java/com/android/go/sopt/winey/util/binding/BindingAdapter.kt
…o feature/feat-create-feed-comment
sxunea
approved these changes
Aug 21, 2023
| @@ -256,14 +256,17 @@ class WineyFeedFragment : BindingFragment<FragmentWineyFeedBinding>(R.layout.fra | |||
|
|
|||
| private fun navigateToDetail(feedId: Int, writerLevel: Int) { | |||
| val intent = Intent(requireContext(), DetailActivity::class.java) | |||
| intent.putExtra("feedId", feedId) | |||
| intent.putExtra("writerLevel", writerLevel) | |||
| intent.putExtra(KEY_FEED_ID, feedId) | |||
| android:text="@string/comment_upload_btn_text" | ||
| android:textAppearance="@style/TextAppearance.WINEY.body_m_14" | ||
| android:textColor="@color/purple_400" | ||
| android:visibility="@{vm.isValidComment ? View.VISIBLE : View.GONE}" |
|
|
||
| if (commentList.isEmpty()) { | ||
| binding.rvDetail.adapter = ConcatAdapter(detailFeedAdapter, commentEmptyAdapter) | ||
| } else { |
There was a problem hiding this comment.
기존의방식(empty layout도 frame Layout에 넣고 isEmpty에 따라 visibility 조절)의 방식을 두고
따로 Empty Adapter를 둔 특별한 이유가 있는지 궁금합니다 ! concat으로 바뀌면서 하단 레이아웃을 갈아끼우기 편해졌고, 댓글 생성창을 또 framelayout으로 넣어야하기 때문에 분리했다고 생각하긴 하는데 또 개인적인 의견이 있었다면 알아가고싶습니다😄
There was a problem hiding this comment.
댓글 부분 레이아웃 짤 때 두 개의 뷰 (댓글이 아직 없어요 뷰, 댓글 리사이클러뷰) 가 겹쳐보여서 보기에 조금 불편한 감이 있더라구요..! 그리고 visibility를 토글하면서 뷰를 전환하다보면 실수할 여지가 많을 거 같아서, 리스트가 비어있을 때는 아예 새로운 레이아웃이 인플레이트 되는 식으로 구현해봤어요 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Work Description
📣 To Reviewers