[ui] 알림 / 알림 뷰 디자인 #123
Merged
[ui] 알림 / 알림 뷰 디자인 #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeeha
requested changes
Aug 19, 2023
| import com.android.go.sopt.winey.util.view.ItemDiffCallback | ||
|
|
||
| class NotificationAdapter : | ||
| PagingDataAdapter<Notification, NotificationAdapter.NotificationViewHolder>(DiffUtil) { |
There was a problem hiding this comment.
알림 리스트는 페이지로 구분되어 있지 않다고 해요! 페이징 대신 그냥 일반적인 ListAdapter 사용하면 될 거 같아요!
| "COMMENTNOTI" -> R.string.notification_comment | ||
| "HOWTOLEVELUP" -> R.string.notification_how_to_levelup | ||
| else -> null | ||
| } |
There was a problem hiding this comment.
_ (언더바) 이용해서 가독성을 좀더 높여주는 건 어떨까요??
ex) RANK_UP_TO_2 DELETE_RANK_DOWN_TO_1 GOAL_FAILED LIKE_NOTI
There was a problem hiding this comment.
NotiType 이라는 enum 클래스를 만들어서, 타입을 구분하면 좋을 거 같아요! 그러면 이렇게 문자열을 하드코딩 하지 않아도 돼서 매우 편하답니다 :)
util/code 패키지에 있는 NicknameErrorCode 라는 enum class 참고해주세요!
There was a problem hiding this comment.
현재는 서버에서 날아오는 NotiType의 항목들이 코드에 적힌 "RANKUPTO2", "COMMENTNOTI" 등의 문자열로 날아오기 때문에 그에 따라서 분기 처리 해주기 위해서 지금처럼 적어두었습니다 ! enum 클래스를 사용하여 구현하는 방식은 알림 서버통신을 구현하면서 제대로 처리되는지 확인해보면서 시도해보겠습니다 !
| if (drawableResourceId != 0) { | ||
| setImageResource(drawableResourceId) | ||
| } else { | ||
| } |
| android:id="@+id/tv_notification_title" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:text="알림" |
sxunea
approved these changes
Aug 19, 2023
leeeha
reviewed
Aug 19, 2023
leeeha
approved these changes
Aug 19, 2023
| "COMMENTNOTI" -> R.string.notification_comment | ||
| "HOWTOLEVELUP" -> R.string.notification_how_to_levelup | ||
| else -> null | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Work Description
알림 뷰 디자인
마이페이지 리디자인
📣 To Reviewers
내일까지 부탁드립니다 !