Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] 마이페이지, 위니업로드 / 닉네임 수정, 회원탈퇴, 리디자인 적용 #118

Merged
merged 24 commits into from
Aug 19, 2023

Conversation

leeeha
Copy link
Member

@leeeha leeeha commented Aug 17, 2023

📝 Work Description

  • 마이페이지에서 닉네임 수정
  • 회원탈퇴 및 다이얼로그
  • 위니 업로드 스낵바 커스텀, 다이얼로그

📣 To Reviewers

  • 내일 오후까지 리뷰 부탁드려요!
  • 원래 별도의 브랜치에서 따로 작업했는데 feat-upload-redesign 브랜치로 모두 머지해서 한번에 PR 올립니다!
  • 커스텀 스낵바는 코드 보면 어떻게 사용하는지 바로 알 수 있을 거예요 :)

…o feature/feat-mypage-nickname-patch

� Conflicts:
�	app/src/main/java/com/android/go/sopt/winey/presentation/splash/SplashActivity.kt
…-winey/Winey-AOS into feature/feat-mypage-nickname-patch

� Conflicts:
�	app/src/main/java/com/android/go/sopt/winey/presentation/splash/SplashActivity.kt
…-winey/Winey-AOS into feature/feat-mypage-nickname-patch

� Conflicts:
�	app/src/main/java/com/android/go/sopt/winey/presentation/nickname/NicknameActivity.kt
…o feature/feat-upload-redesign

� Conflicts:
�	app/src/main/java/com/android/go/sopt/winey/presentation/main/mypage/MyPageFragment.kt
�	app/src/main/res/values/strings.xml
@leeeha leeeha added feat ✨ 새로운 기능 구현 하은 🐰 labels Aug 17, 2023
@leeeha leeeha added this to the 기능 구현 ✨ milestone Aug 17, 2023
@leeeha leeeha self-assigned this Aug 17, 2023
Copy link
Contributor

@Sangwook123 Sangwook123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! ! 어푸!

Timber.e("FAIL GET USER IN MAIN: ${t.code()}")

// todo: 메인 액티비티가 아니라 여기서 t.code() 이용해서
// 리프레시 토큰 만료되면 로그아웃 되게 해야 될 거 같아요!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인확인 !!

@@ -125,7 +190,8 @@ class MyPageFragment : BindingFragment<FragmentMyPageBinding>(R.layout.fragment_
}
}

private fun handleSuccessState(data: User?) {
// todo: 여기 한 함수에 들어가는 코드량이 많습니다! 함수화 시켜주세요! @우상욱
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다 !

@leeeha leeeha merged commit 22bf400 into develop Aug 19, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat ✨ 새로운 기능 구현 하은 🐰
Projects
Status: Done
2 participants