[feat] 온보딩 / 가이드, 스토리, 닉네임 기능 구현 #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feature/ui-onboarding-guide
…o feature/ui-onboarding-guide � Conflicts: � app/src/main/AndroidManifest.xml
…b.com/team-winey/Winey-AOS into feature/ui-onboarding-guide � Conflicts: � app/src/main/AndroidManifest.xml
…b.com/team-winey/Winey-AOS into feature/ui-onboarding-guide
…com/team-winey/Winey-AOS into feature/ui-onboarding-guide � Conflicts: � app/src/main/java/com/android/go/sopt/winey/presentation/splash/SplashActivity.kt
…o feature/ui-onboarding-guide # Conflicts: # app/src/main/res/layout/fragment_level_guide.xml
…-guide # Conflicts: # app/src/main/java/com/android/go/sopt/winey/presentation/splash/SplashActivity.kt # app/src/main/res/layout/activity_guide.xml
- popBackStack 명시적으로 호출하기
…o feature/ui-onboarding-guide � Conflicts: � app/src/main/java/com/android/go/sopt/winey/data/repository/AuthRepositoryImpl.kt � app/src/main/java/com/android/go/sopt/winey/data/service/AuthService.kt � app/src/main/java/com/android/go/sopt/winey/data/source/AuthDataSource.kt � app/src/main/java/com/android/go/sopt/winey/domain/repository/AuthRepository.kt � app/src/main/java/com/android/go/sopt/winey/presentation/main/feed/upload/amount/AmountViewModel.kt
…o feature/ui-onboarding-guide � Conflicts: � app/src/main/java/com/android/go/sopt/winey/presentation/splash/SplashActivity.kt
Sangwook123
approved these changes
Aug 16, 2023
| } | ||
| } | ||
| } | ||
| onBackPressedDispatcher.addCallback(this, callback) |
There was a problem hiding this comment.
오 이런식으로 뒤로가기 이벤트 설정이 가능하군요 👏👏
| @@ -53,7 +53,7 @@ class NicknameActivity : BindingActivity<ActivityNicknameBinding>(R.layout.activ | |||
|
|
|||
| private fun initCompleteButtonClickListener() { | |||
| binding.btnNicknameComplete.setOnClickListener { | |||
| // todo: 서버에 닉네임 PATCH | |||
| viewModel.patchNickname() | |||
| navigateTo<MainActivity>() | |||
There was a problem hiding this comment.
patchNickname()이 onSuccess되었을때만 MainActivity로 넘어가게하는건 어떤가요? 중복확인후 닉네임변경 버튼을 누르는 사이에 다른 유저가 해당 닉네임으로 변경했을경우 409 에러(닉네임 중복) 가 뜰 수도 있을것 같습니다 !
There was a problem hiding this comment.
뷰모델에서 서버통신 결과를 가져와서 그에 따라 UI를 갱신하는 코드가 빠져있네요! 좋은 지적 감사합니다 :)
…-winey/Winey-AOS into feature/ui-onboarding-guide � Conflicts: � app/src/main/res/layout/fragment_first_story.xml � app/src/main/res/layout/fragment_second_story.xml � app/src/main/res/layout/fragment_third_story.xml
…o feature/ui-onboarding-guide # Conflicts: # app/src/main/java/com/android/go/sopt/winey/presentation/splash/SplashActivity.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Work Description
📣 To Reviewers