-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#278 [refactor] deprecated된 함수 수정 및 네트워크 에러 분기처리 #279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아휴 이놈의 버전,, 너무 고생했어요👍🏻👍🏻
val androidForceVersion: String = "", | ||
val versionText: String = "" | ||
) : Parcelable | ||
fun greaterThan(other: Version): Boolean = other.major < major || other.minor < minor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
boolean 을 반환하는 경우는 isGreaterThan처럼 보통 쓴다고 알고 있는데 혹시 어떤가요!?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
boolean 을 반환하는 경우는 isGreaterThan처럼 보통 쓴다고 알고 있는데 혹시 어떤가요!?
모든 boolean에 is 접두사를 붙일 필요는 없어요!
greaterThan이 ~보다 크다 라는 뜻의 함수로 쓰인 거라 greaterThan(cutrentVersion)이라면 현재 버전보다 높다(false라면 낮다)이기 때문에 boolean이라 예상 가능해보입니다
isGreaterThan이라면 is가 불용어가 될 거 같아용
import com.sopt.peekabookaos.util.extensions.initBackPressedCallback | ||
import com.sopt.peekabookaos.util.extensions.setSingleOnClickListener | ||
|
||
class ForcedUpdateActivity : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아예 액티비티를 만드셨군요..!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
함수 수정 확인했습니다! 바쁜데도 고생많아요
import retrofit2.http.GET | ||
|
||
interface ForcedUpdateService { | ||
@GET("user/v1/version") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍👍👍👍
관련 이슈
작업 사진/동영상 (선택)
작업한 내용
PR 포인트