#276 [build] SDK 34 업그레이드 #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2zerozu
changed the title
2zerozu
changed the title
stellar-halo
approved these changes
Nov 24, 2023
stellar-halo
approved these changes
Nov 24, 2023
Comment on lines
+6
to
+12
| fun Activity.activityTransition(transitionType: Int, enterAnim: Int, exitAnim: Int) { | ||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.UPSIDE_DOWN_CAKE) { | ||
| overrideActivityTransition(transitionType, enterAnim, exitAnim) | ||
| } else { | ||
| overridePendingTransition(enterAnim, exitAnim) | ||
| } | ||
| } |
There was a problem hiding this comment.
새로 생긴 util이네요. overrideActivityTransition가 Android 14에 추가된 함수인 것 같은데 맞나요?
There was a problem hiding this comment.
새로 생긴 util이네요. overrideActivityTransition가 Android 14에 추가된 함수인 것 같은데 맞나요?
맞아요 .. overridePendingTransition 대신 overrideActivityTransition 사용해야 하더라구요 ㅠ
There was a problem hiding this comment.
떼잉~ 버전에 따라 자꾸 노나야 하는 게 생기네요
hajeong67
approved these changes
Nov 25, 2023
| } | ||
| buildFeatures { | ||
| buildConfig true |
There was a problem hiding this comment.
얘가 추가로 필요해진 이유가 뭔가요?
Sdk 34부터 추가해야한다고 하네요
이제 buildConfig도 없어질 예정이라고 하더이다^__^..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 사진/동영상 (선택)
작업한 내용
PR 포인트 (라고 쓰고 실행이 안 된다면 참고할 부분)