#273 [feat] 앱 버전이 맞지 않을 경우, 업데이트 화면 뜨게 하기 #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 3, 2023 05:03
…Impl, Service, UseCase)
… 메인으로 띄울지, 버전 업데이트 안내문구 띄울지 결정
2zerozu
requested changes
Nov 2, 2023
app/src/main/java/com/sopt/peekabookaos/domain/entity/Version.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/sopt/peekabookaos/presentation/forceUpdate/ForceUpdateActivity.kt
Outdated
Show resolved
Hide resolved
| @Serializable | ||
| data class VersionResponse( | ||
| val imageUrl: String, | ||
| val iosForceVersion: String, |
There was a problem hiding this comment.
현재 우리는 iOSForceVersion이라는 변수가 필요하지 않습니다!
json에는 ignoreUnknownKey라는 키워드가 있는데 다음에 공부해서 리팩토링 해봅시다
|
|
||
| @Serializable | ||
| data class VersionResponse( | ||
| val imageUrl: String, |
There was a problem hiding this comment.
imageUrl이 현재 뷰에는 쓰이지 않는데 nullable 변수인지 서버한테 물어보면 좋을 것 같네요
app/src/main/java/com/sopt/peekabookaos/presentation/splash/SplashActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/sopt/peekabookaos/presentation/splash/SplashActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/sopt/peekabookaos/presentation/splash/SplashViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/sopt/peekabookaos/presentation/splash/SplashActivity.kt
Outdated
Show resolved
Hide resolved
Comment on lines
20
to
23
| private val _versionName: MutableLiveData<String> = MutableLiveData() | ||
| val versionName: LiveData<String> = _versionName | ||
| private val _isVersionStatus = MutableLiveData(false) | ||
| val isVersionStatus: LiveData<Boolean> = _isVersionStatus |
There was a problem hiding this comment.
UiState라는 데이터클래스를 만들어서 변수를 하나에 관리하는 건 어떨까요?
There was a problem hiding this comment.
당장은 여기에서만 쓰이니 안만드는게 좋겠다고 생각했는데, 나중엔 다른 곳에서도 쓰일 수도 있겠네요..!
There was a problem hiding this comment.
음 .. 개인적으론 코딩스타일인 것 같아서 다음에 uiState 공부하고 적용해보면 좋을 것 같아요
app/src/main/java/com/sopt/peekabookaos/presentation/splash/SplashActivity.kt
Outdated
Show resolved
Hide resolved
2zerozu
changed the title
2zerozu
reviewed
Nov 3, 2023
Comment on lines
22
to
23
| private val _isVersionStatus = MutableLiveData(false) | ||
| val isVersionStatus: LiveData<Boolean> = _isVersionStatus |
There was a problem hiding this comment.
isVersionStatus보다는 isForceUpdate가 더 직관적인 것 같은데 어떻게 생각하시나요?
There was a problem hiding this comment.
서버 통신 변수명이니까 status가 들어가는 것이 좋아보여 isForceUpdateStatus로 변경했습니다
hajeong67
approved these changes
Nov 3, 2023
| import retrofit2.http.GET | ||
|
|
||
| interface ForceUpdateService { | ||
| @GET("user/v1/version") |
2zerozu
requested changes
Nov 5, 2023
app/src/main/java/com/sopt/peekabookaos/presentation/forceUpdate/ForceUpdateActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/sopt/peekabookaos/presentation/forceUpdate/ForceUpdateViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/sopt/peekabookaos/presentation/splash/SplashActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/sopt/peekabookaos/presentation/splash/SplashActivity.kt
Show resolved
Hide resolved
Comment on lines
21
to
25
| var latestVersion = Version() | ||
| private val _isForceUpdateStatus = MutableLiveData(false) | ||
| val isForceUpdateStatus: LiveData<Boolean> = _isForceUpdateStatus | ||
| lateinit var majorVersion: String | ||
| lateinit var minorVersion: String |
There was a problem hiding this comment.
로직 변경해서 바뀐 변수들은 private으로 처리했습니다
app/src/main/java/com/sopt/peekabookaos/presentation/splash/SplashActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/sopt/peekabookaos/presentation/splash/SplashActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/sopt/peekabookaos/presentation/splash/SplashActivity.kt
Outdated
Show resolved
Hide resolved
stellar-halo
deleted the
feature/#273-feat-bookshelf-version-update-notification
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 사진/동영상 (선택)
KakaoTalk_20231105_234405670.mp4
작업한 내용
PR 포인트