fix: allow overriding strategy defaults #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachdaniel
force-pushed
the
allow-overriding-strategy-defaults
branch
3 times, most recently
from
6e96586
to
e93a9ac
Compare
|
@jimsynz i was having trouble locally with asdf so I updated the .tool-versions file. But now we have what I think are unrelated dialyzer errors. However something strange is happening with dialyzer locally, I think because an explicit PLT file is configured? What is the reason for that? Could you take a look at the failures? |
`auto_set_fields` doesn't set defaults, it sets the values *always* and so things like `authorization_params` were not settable fixes #764
jimsynz
force-pushed
the
allow-overriding-strategy-defaults
branch
from
e93a9ac
to
02f8a85
Compare
|
@zachdaniel dialyzer issues fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
auto_set_fieldsdoesn't set defaults, it sets the values always and so things likeauthorization_paramswere not settable