chore: add false filter on nil identity_field

team-alembic · Aug 12, 2024 · 0a87b71 · 0a87b71
1 parent ccd0eb0
commit 0a87b71
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/.tool-versions b/.tool-versions
diff --git a/lib/ash_authentication/strategies/password/sign_in_preparation.ex b/lib/ash_authentication/strategies/password/sign_in_preparation.ex
@@ -25,8 +25,15 @@ defmodule AshAuthentication.Strategy.Password.SignInPreparation do
     identity_field = strategy.identity_field
     identity = Query.get_argument(query, identity_field)
 
+    query =
+      if is_nil(identity) do
+        # This will fail due to the argument being `nil`, so this is just a formality
+        Query.filter(query, false)
+      else
+        Query.filter(query, ^ref(identity_field) == ^identity)
+      end
+
     query
-    |> Query.filter(^ref(identity_field) == ^identity)
     |> check_sign_in_token_configuration(strategy)
     |> Query.before_action(fn query ->
       Ash.Query.ensure_selected(query, [strategy.hashed_password_field])