refactor: 코드 리팩토링 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4 tasks
yoonsseo
approved these changes
Apr 8, 2024
| public List<HomeFragrance> searchV1(@RequestParam String family){ | ||
| return homeService.search(family); | ||
| public List<HomeFragranceDto> searchMainFragranceV1(@RequestParam String family){ | ||
| return homeService.searchMainFragrance(family); |
There was a problem hiding this comment.
의미 있는 이름으로 변경해주셔서 어떤 일을 수행하는 메소드인지 더 잘 파악할 수 있는 것 같아용👍🏻👍🏻
|
|
||
| @Repository | ||
| public interface FamilyRepository extends JpaRepository<Family, Long>{ | ||
| boolean existsByKorName(String korName); | ||
| Family findByKorName(String korName); | ||
| Optional<Family> findByKorName(String korName); |
There was a problem hiding this comment.
헉 옵셔널로 감싸두지 않았었군요..!
옵셔널로 감싸는 이유는 뭐가 있을까요??😆😆
There was a problem hiding this comment.
NULL 체크를 빼먹거나 아니면 불필요하게 체크하는 일을 방지하기 위해서죠!
그 전에는 급하게 구현하다보니 Optional로 감싸는 걸 까먹었습니다..🥲
| Page<DisplayFragrance> searchByFilter(FragranceFilterCond cond, String additionalFamily, Pageable pageable); | ||
| Page<FragranceCatalogDto> searchByBrandAndFamily(FragranceFilterCond cond, Pageable pageable); |
There was a problem hiding this comment.
여기에서 addtionalFamily가 빠진 이유는 무엇인가욥??👀👀
Comment on lines
-80
to
+78
| public DisplayIngredient getIngredientContent(String ingredient) { | ||
| // 향료가 존재하는지 확인 후 조회 | ||
| if(!ingredientRepository.existsByKorName(ingredient)) throw new CustomException(ErrorCode.INGREDIENT_NOT_FOUND); | ||
| Ingredient findIngredient = ingredientRepository.findByKorName(ingredient); | ||
|
|
||
| // 향료에 해당하는 향료 타입이 존재하는지 확인 후 조회 | ||
| IngredientType findIngredientType = ingredientTypeRepository.findById(findIngredient.getIngredientType().getId()) | ||
| .orElseThrow(()-> new CustomException(ErrorCode.INGREDIENT_TYPE_NOT_FOUND)); | ||
| public IngredientDetailsDto getIngredientContent(String ingredient) { | ||
| Ingredient findIngredient = ingredientRepository.findByKorName(ingredient) | ||
| .orElseThrow(() -> new CustomException(ErrorCode.INGREDIENT_NOT_FOUND)); |
| @Repository | ||
| public interface IngredientRepository extends JpaRepository<Ingredient, Long>, IngredientRepositoryCustom { | ||
|
|
||
| Ingredient findByKorName(String korName); | ||
| Optional<Ingredient> findByKorName(String korName); |
There was a problem hiding this comment.
이전에는 Optional을 붙여주지 않았던 이유가 뭔가욥??🤔🤔
There was a problem hiding this comment.
위에서 말했듯 급하게 작성하다보니 누락하였습니당ㅜ..
Comment on lines
+32
to
+33
| @Version | ||
| private Long version; |
| @OneToOne(fetch = FetchType.LAZY) | ||
| @JoinColumn(name = "fragrance_id") | ||
| private Fragrance fragrance; | ||
|
|
||
| public void updateVariable(String intensity, int value){ |
There was a problem hiding this comment.
String intensity = review.getIntensity().toString().toLowerCase(); // 향의 세기
reviewUpdateRepository.updateIntensity(intensity, review.getFragrance().getId(), -1);원래 이렇게 작성하였는데 객체 내에 setter로직을 사용하면 데이터 변경 시 엔티티의 일관성을 유지하기 쉽고 객체지향적인 설계를 유지할 수 있다 생각하여 변경하였습니다!
다만 두 가지 방법 각각 장단점이 있어 같이 이야기해봐도 좋을 것 같아요!
| class ReviewServiceTest { | ||
|
|
||
| @Autowired ReviewService reviewService; | ||
| @Autowired FragranceRepository fragranceRepository; | ||
| @Autowired ReviewSeasonRepository reviewSeasonRepository; | ||
|
|
||
| @DisplayName("리뷰 작성/ 삭제가 여러 스레드에서 일어날 때 reviewCnt 일관성 유지 테스트") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR
PR 요약
변경된 점
테스트가 repeatable 하기 위해서 h2 in memory db 사용하도록 환경설정 수정하였습니다.
@ActiveProfiles("test")어노테이션 이용하면 됩니다.리뷰 통계 엔티티에는 낙관적 락을, 향수 엔티티의 특정 속성에는 비관적 락을 적용하여 동시성 처리하였습니다.
예외 처리 세부적으로 추가하였고
System.out.println대신 로그로 수정하였습니다.메소드 명이나 엔티티 명이 의미가 더 잘 드러나도록 수정하였습니다.
그 외 자잘한 코드 리팩토링을 거쳤습니다.
모든 테스트 통과하도록 수정하였습니다. 확인해보고 안되면 말해주세욥!
이슈 번호
close #34