Fix for multi select custom fields when saving #18

Chucheen · 2016-09-11T02:36:06Z

For a multi_select custom_field type, amoCRM demands to be a direct array

[
   "id"=>692250,       //field id
   "values"=> [1662884,1662886]    //Field of multiselect type (an array of values is allowed)
],

instead of

[
  "id"=>691606,       //field id
  "values"=> [
    [
      "value"=>1519210  //Field of list type, enum parameter value is assigned to the field value
    ]
  ]
]

The multi select fields were not being stored from the beginning or when updated. This commit changes the way it's sent and fixes that

For a multi_select field type, amoCRM demands to be a direct array instead of a values: { [value: '1']}. This commit fixes the way it's sent

Chucheen · 2016-09-12T02:52:04Z

Apparently Travis failed because of resolving or installing some dependencies

alekseenkoss77 · 2016-09-14T14:02:16Z

lib/amorail/entity/params.rb

        prop_id = props.send(k).id
-        prop_val = { value: send(k) }.merge(v)
-        custom_fields << { id: prop_id, values: [prop_val] }
+        prop_val = props.send(k)['type_id'] == "5" ? [send(k)] : { value: send(k) }.merge(value)


what is "5" ? Can you explain ? I think you can use constant for that.

I changed it to use a constant instead. It's the field id for a multiselect type of field.
https://developers.amocrm.com/rest_api/accounts_current.php#type_id

palkan · 2017-10-01T12:47:12Z

@ivanovaleksey Could you, please, take a look?

Fix for multi select custom fields when saving

58c7ca0

For a multi_select field type, amoCRM demands to be a direct array instead of a values: { [value: '1']}. This commit fixes the way it's sent

alekseenkoss77 reviewed Sep 14, 2016
View reviewed changes

Using constant for multiselect type

3bc5982

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix for multi select custom fields when saving #18

Fix for multi select custom fields when saving #18

Chucheen commented Sep 11, 2016

Chucheen commented Sep 12, 2016

alekseenkoss77 Sep 14, 2016

Chucheen Sep 14, 2016

palkan commented Oct 1, 2017

Fix for multi select custom fields when saving #18

Are you sure you want to change the base?

Fix for multi select custom fields when saving #18

Conversation

Chucheen commented Sep 11, 2016

Chucheen commented Sep 12, 2016

alekseenkoss77 Sep 14, 2016

Choose a reason for hiding this comment

Chucheen Sep 14, 2016

Choose a reason for hiding this comment

palkan commented Oct 1, 2017