[sync] fix: record history filter dropdowns cannot scroll inside modal dialog#3570
[sync] fix: record history filter dropdowns cannot scroll inside modal dialog#3570tea-artist wants to merge 1 commit into
Conversation
…l dialog Synced from teableio/teable-ee@8eddf3d Co-authored-by: Aries X <caoxing9@gmail.com> Co-authored-by: Bieber <artist@teable.io> Co-authored-by: Jocky Zhou <jocky@teable.ai> Co-authored-by: Jun Lu <hammond@teable.io> Co-authored-by: Pengap <penganpingprivte@gmail.com> Co-authored-by: SkyHuang <sky.huang.fe@gmail.com> Co-authored-by: Uno <uno@teable.ai> Co-authored-by: nichenqin <nichenqin@hotmail.com>
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e34efe7419
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let isNewUser = false; | ||
| // Risk control first, before the transaction — a slow risk service must | ||
| // never hold a database connection. | ||
| await this.throwIfEmailDeniedByRiskControl('signup', user.email); |
There was a problem hiding this comment.
Don't risk-check existing OAuth sign-ins
When the risk service is configured and denies an address/domain, this check runs before the existing OAuth account lookup below, so findOrCreateUser rejects even users who already have a linked OAuth account instead of just blocking new signups. That makes previously registered social-login users unable to sign in, while password login is not subject to the same signup-only risk check; move the risk call to the branch that actually creates a new account/user, or at least after the existing account lookup.
Useful? React with 👍 / 👎.
🧹 Preview Environment Cleanup
|
🔄 Automated sync from EE repository.
66 commit(s) synced since last sync.
Authors
Included commits
Latest source commit: teableio/teable-ee@8eddf3d
This PR was automatically created by the sync workflow.