Skip to content

Conversation

@younocode
Copy link
Contributor

No description provided.

@younocode younocode requested a review from Copilot October 20, 2025 11:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the base delete event to support permanent deletion by adding a permanent flag that bypasses trash creation when set to true.

  • Added permanent parameter to base delete events to distinguish between soft and permanent deletions
  • Modified the trash listener to skip trash creation for permanent deletions
  • Updated the event factory and interceptor to properly handle the permanent deletion flag

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
apps/nestjs-backend/src/features/base/base.controller.ts Added event emission and permanent flag to permanent delete endpoint
apps/nestjs-backend/src/event-emitter/listeners/trash.listener.ts Added logic to skip trash creation for permanent deletions
apps/nestjs-backend/src/event-emitter/interceptor/event.Interceptor.ts Separated BASE_DELETE event handling from other base events
apps/nestjs-backend/src/event-emitter/events/base/base.event.ts Updated event payload structure to include permanent flag

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@younocode younocode requested a review from boris-w October 21, 2025 05:59
@younocode younocode force-pushed the fix/base-delete-handle branch 3 times, most recently from 53ba02a to 4ecfe60 Compare October 27, 2025 02:34
@younocode younocode force-pushed the fix/base-delete-handle branch from 4ecfe60 to 94161b4 Compare October 29, 2025 02:33
@younocode younocode force-pushed the fix/base-delete-handle branch from 94161b4 to 40373c7 Compare October 30, 2025 10:54
@younocode younocode force-pushed the fix/base-delete-handle branch from 40373c7 to 0b21499 Compare November 3, 2025 02:55
@younocode younocode force-pushed the fix/base-delete-handle branch from 22f0b93 to 979f9d3 Compare November 3, 2025 05:12
@younocode younocode merged commit 5d4a78a into develop Nov 3, 2025
13 of 14 checks passed
@younocode younocode deleted the fix/base-delete-handle branch November 3, 2025 06:01
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

🧹 Preview Environment Cleanup

tea-artist pushed a commit that referenced this pull request Nov 13, 2025
* fix: enhance base delete event to support permanent deletion

* refactor: remove deprecated base deletion method in user last visit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants